GeezerVison

Original file line number	Diff line number	Diff line change
Expand Up		@@ -39,32 +39,44 @@
		#
		# $Id$


		class ControlSlycot(Exception):
		"""Exception for Slycot import. Used when we can't import a function
		from the slycot package"""
		pass
		def __init__(self, error):
Comment thread repagh Apr 16, 2019 Copy link Copy Markdown Member There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. I don't think it is the right approach to immediately print this error reason. This creates an exception with a by-product. This also does not call Exception.init, (which would normally store the error string) so if caught and printed later, the original exception reason has disappeared. Sorry, something went wrong. Uh oh! There was an error while loading. Please reload this page. All reactions
		print("slycot import failed")
		print(error)


		class ControlDimension(Exception):
		"""Raised when dimensions of system objects are not correct"""
		pass


		class ControlArgument(Exception):
		"""Raised when arguments to a function are not correct"""
		pass


		class ControlMIMONotImplemented(Exception):
		"""Function is not currently implemented for MIMO systems"""
		pass


		class ControlNotImplemented(Exception):
		"""Functionality is not yet implemented"""
		pass


		# Utility function to see if slycot is installed
		def slycot_check():
		try:
		import slycot
		except:
		except ImportError as error:
		print(error)
		return False
		except Exception as exception:
		print(exception, False)
		return False
		else:
		return True

Oops, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Refactor place method #268

Uh oh!

Refactor place method #268

Uh oh!

Uh oh!

Diff view

Diff view

There are no files selected for viewing

repagh Apr 16, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!