GeezerVison is showing github.com — fix testMimoW123 by bnavigator · Pull Request #320 · python-control/python-control
Conversation
bnavigator
commented
Jun 27, 2019
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
This fixes #190
Because the tf(minreal(g-h)) in siso_almost_equal misses to remove all unobservable states in h (=p[i,j]), the transfer function has a higher order and exceeds the numerical limit on some build systems.
Ran into this while trying to build a package for OpenSUSE on their build system. With the patch, the package builds fine
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Coverage increased (+0.02%) to 82.121% when pulling 4ec1678 on bnavigator:fix-augwtest into 662e52e on python-control:master.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
2 similar comments
|
Coverage increased (+0.02%) to 82.121% when pulling 4ec1678 on bnavigator:fix-augwtest into 662e52e on python-control:master.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Coverage increased (+0.02%) to 82.121% when pulling 4ec1678 on bnavigator:fix-augwtest into 662e52e on python-control:master.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Fix seems fine. Need to resolve issue #321 before merging into master to avoid breaking CI tests.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
murrayrm
pushed a commit
that referenced
this pull request
Jan 5, 2020
PR #314 duplicates a lot of code in the test cases by introducing *_array_test.py files. Thus issue #190 addressed in PR #320 resurfaces and needs to be introduced to robust_array_test.pyas well.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
