GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — handle non proper tf in _common_den() by bnavigator · Pull Request #370 · python-control/python-control

Conversation

@bnavigator

@bnavigator bnavigator commented Jan 28, 2020

Copy link
Copy Markdown
Contributor

Proposed fix for #369

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bnavigator
handle non proper tf in _common_den()
16498d1
@coveralls

coveralls commented Jan 28, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Coverage Status

Coverage increased (+2.5%) to 84.625% when pulling a0986c5 on bnavigator:fix-369 into 66bee9d on python-control:master.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bnavigator bnavigator mentioned this pull request Jan 28, 2020
coverall reports coverage decrease despite tests being added #349
Closed
repagh
repagh reviewed Mar 2, 2020
View reviewed changes

@repagh repagh left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. If I am not mistaken it can be simplified a little

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread control/xferfcn.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
murrayrm
murrayrm reviewed Mar 18, 2020
View reviewed changes

@murrayrm murrayrm left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but a couple of small suggestions. If you can reject or update, I'll merge when done.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread control/xferfcn.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread control/xferfcn.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bnavigator
rename to allow_nonproper
a0986c5
@murrayrm
murrayrm merged commit a09d059 into python-control:master Mar 21, 2020
@murrayrm murrayrm mentioned this pull request Jul 11, 2020
Bug in xferfcn.py #369
Closed
@bnavigator
bnavigator deleted the fix-369 branch July 26, 2020 14:39
@murrayrm murrayrm mentioned this pull request Dec 31, 2020
generate error for tf2ss of non-proper transfer function #492
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@murrayrm murrayrm murrayrm left review comments
@repagh repagh repagh left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@bnavigator @coveralls @murrayrm @repagh
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.