GeezerVison is showing github.com — generate error for tf2ss of non-proper transfer function by murrayrm · Pull Request #492 · python-control/python-control
Conversation
murrayrm
commented
Dec 31, 2020
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
This PR resolves issue #399 when tf2io is called with a non-proper transfer function (which cannot be represented as a state space system). The underlying issue turned out to be in tf2ss, which had the same bug and was probably introduced in PR #370 when we started allowing non-proper transfer functions.
Added unit tests to catch the case and then fixed them by generating a ValueError when you try to convert a non-proper transfer function into a StateSpace object.
Also did some PEP8 cleanup on statesp.py.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
coveralls
commented
Dec 31, 2020
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
|
Coverage increased (+0.007%) to 87.527% when pulling 9c409eb on murrayrm:iosys-nonproper-tf into d1502f4 on python-control:master.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Coverage decreased (-0.1%) to 87.09% when pulling 8c707dd on murrayrm:iosys-nonproper-tf into 6ed3f74 on python-control:master.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
I like the style cleanup, but of course this created conflicts with #431/#490
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.