GeezerVison is showing github.com — fix impulse size for discrete-time impulse response by sawyerbfuller · Pull Request #447 · python-control/python-control
Conversation
The input impulse used to drive the impulse response of a discrete-time system should be unit area rather than unit height. With this change, the discrete-time system's impulse response matches the cont-time systems's, if the discrete time system was sampled with 'impulse-equivalent' approximation according to:
sysd = sys.sample(0.1, 'impulse')
A new unit test checks this.
(this is consistent with MATLAB behavior)
Update: rewrote summary, last version was written after a long work session and it shows : )
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
|
Coverage decreased (-0.1%) to 84.074% when pulling 0b85e3b on sawyerbfuller:fix-dt-impulse-size into d3142ff on python-control:master.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
bnavigator
added a commit
that referenced
this pull request
Dec 29, 2020
merging #447, which did not fail in the PR tests, started to fail master after the merge, because `cont2discrete(..., 'impulse')` fails.
Following NEP 29 we could even drop 3.6. But that is still active in distributions like openSUSE Leap 15.x, so I would like to keep that.
This was referenced Dec 29, 2020
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.