GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — implementation of initial_phase, wrap_phase keywords for bode() by murrayrm · Pull Request #494 · python-control/python-control

Conversation

@murrayrm

@murrayrm murrayrm commented Dec 31, 2020

Copy link
Copy Markdown
Member

This PR adds initial_phase and wrap_phase keywords to bode, which allow you to tune the behavior of the phase portion of a Bode plot. The default behavior should more or less match previous behavior, except that the default initial phase will be between 0 and -360 degrees (so 1/s^3 will start with phase -270).

Resolves issue #467.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@murrayrm
implementation of initial_phase, wrap_phase keywords for bode()
775b03f
@coveralls

coveralls commented Dec 31, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.002%) to 87.53% when pulling 2702ee7 on murrayrm:bode_initial_wrap_phase into 383e7a4 on python-control:master.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@coveralls

coveralls commented Dec 31, 2020

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.1%) to 87.391% when pulling 775b03f on murrayrm:bode_initial_wrap_phase into 383e7a4 on python-control:master.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bnavigator
bnavigator requested changes Jan 1, 2021
View reviewed changes
Comment thread control/freqplot.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread control/tests/freqresp_test.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread control/tests/freqresp_test.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
murrayrm added 2 commits January 2, 2021 07:50
@murrayrm
add additional documentation on initial_phase if deg=False
fe9928b
@murrayrm
clear figure in unit tests to avoid slow plotting problem
2702ee7
bnavigator
bnavigator approved these changes Jan 2, 2021
View reviewed changes
@bnavigator
bnavigator merged commit 5125ff7 into python-control:master Jan 2, 2021
@bnavigator bnavigator mentioned this pull request Jan 3, 2021
Phase shift in bode plot #467
Closed
3 tasks done
murrayrm added a commit to murrayrm/python-control that referenced this pull request Jan 4, 2021
@murrayrm
implementation of initial_phase, wrap_phase keywords for bode() (pyth…
3d2da78 
…on-control#494)

* implementation of initial_phase, wrap_phase keywords for bode()

* add additional documentation on initial_phase if deg=False

* clear figure in unit tests to avoid slow plotting problem
@murrayrm murrayrm mentioned this pull request Jan 4, 2021
Allow the initial phase of a bode plot to be specified #388
Closed
@murrayrm
murrayrm deleted the bode_initial_wrap_phase branch January 5, 2021 06:39
@murrayrm murrayrm added this to the 0.9.0 milestone Mar 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnavigator bnavigator bnavigator approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.9.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@murrayrm @coveralls @bnavigator
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.