GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — REBASE: use __call__ instead of evalfr in lti system classes by murrayrm · Pull Request #499 · python-control/python-control

Conversation

@murrayrm

@murrayrm murrayrm commented Jan 6, 2021

Copy link
Copy Markdown
Member

This is a rebase of PR #449.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@murrayrm
rebase sawyerbfuller-call-method against master
195bec3
@murrayrm murrayrm mentioned this pull request Jan 6, 2021
use __call__ instead of evalfr in lti system classes #449
Merged
@murrayrm
murrayrm requested review from bnavigator and sawyerbfuller January 6, 2021 19:44
@murrayrm

murrayrm commented Jan 6, 2021

Copy link
Copy Markdown
Member Author

Requesting a second look from @bnavigator, @sawyerbfuller just to make sure it all still looks OK. Will merge as soon as they approve.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bnavigator

bnavigator commented Jan 6, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The change for frd_test.py::test_eval() got lost.

Fix in 73fc6a6

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bnavigator
bnavigator reviewed Jan 6, 2021
View reviewed changes
Comment thread control/tests/margin_test.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

bnavigator
bnavigator reviewed Jan 6, 2021
View reviewed changes
Comment thread control/tests/statesp_test.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

bnavigator
bnavigator reviewed Jan 6, 2021
View reviewed changes
Comment thread control/tests/statesp_test.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

bnavigator
bnavigator reviewed Jan 6, 2021
View reviewed changes
Comment thread control/tests/statesp_test.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

bnavigator
bnavigator reviewed Jan 6, 2021
View reviewed changes
Comment thread control/tests/xferfcn_test.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

bnavigator
bnavigator reviewed Jan 6, 2021
View reviewed changes
Comment thread control/tests/xferfcn_test.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

@bnavigator

bnavigator commented Jan 6, 2021

Copy link
Copy Markdown
Contributor

@sawyerbfuller are you okay with this single commit squashing all your contributions? Otherwise you could merge (not pick!) the commit into your origin:call-method. (See sawyerbfuller#1 (comment))

Let's also wait on Travis. The scheduler is particularly slow today.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bnavigator bnavigator mentioned this pull request Jan 6, 2021
Rebase of call-method against current master sawyerbfuller/python-control#1
Closed
@coveralls

coveralls commented Jan 6, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.2%) to 87.32% when pulling 195bec3 on murrayrm:call-method_rebase into 4103688 on python-control:master.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bnavigator

bnavigator commented Jan 6, 2021

Copy link
Copy Markdown
Contributor

I pushed your rebase into #449. We can continue discussion in the original PR.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bnavigator bnavigator closed this Jan 6, 2021
@murrayrm

murrayrm commented Jan 6, 2021

Copy link
Copy Markdown
Member Author

Thanks, @bnavigator.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@sawyerbfuller

sawyerbfuller commented Jan 6, 2021

Copy link
Copy Markdown
Contributor

@sawyerbfuller are you okay with this single commit squashing all your contributions? Otherwise you could merge (not pick!) the commit into your origin:call-method.

is this still relevant now that #449 is now (mostly) rebased?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bnavigator

bnavigator commented Jan 6, 2021

Copy link
Copy Markdown
Contributor

I addressed all my comments and pushed into your branch. Even with your small edit in between. Hooray for git 😀

sawyerbfuller reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@murrayrm
murrayrm deleted the call-method_rebase branch January 14, 2021 07:05
@murrayrm murrayrm modified the milestone: 0.9.0 Mar 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnavigator bnavigator bnavigator left review comments
@sawyerbfuller sawyerbfuller Awaiting requested review from sawyerbfuller

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@murrayrm @bnavigator @coveralls @sawyerbfuller
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.