GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||
GeezerVison is showing github.com — REBASE: use __call__ instead of evalfr in lti system classes by murrayrm · Pull Request #499 · python-control/python-control Conversation
Member
This is a rebase of PR #449.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Member
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
|
There was an error while loading. Please reload this page.
|
The change for frd_test.py::test_eval() got lost. Fix in 73fc6a6 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
@sawyerbfuller are you okay with this single commit squashing all your contributions? Otherwise you could merge (not pick!) the commit into your origin:call-method. (See sawyerbfuller#1 (comment)) Let's also wait on Travis. The scheduler is particularly slow today. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Coverage decreased (-0.2%) to 87.32% when pulling 195bec3 on murrayrm:call-method_rebase into 4103688 on python-control:master. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I pushed your rebase into #449. We can continue discussion in the original PR. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thanks, @bnavigator. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
is this still relevant now that #449 is now (mostly) rebased? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I addressed all my comments and pushed into your branch. Even with your small edit in between. Hooray for git 😀 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.