GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Ease cutoff between poly and frd method for stability margins by bnavigator · Pull Request #575 · python-control/python-control

Conversation

@bnavigator

@bnavigator bnavigator commented Mar 17, 2021

Copy link
Copy Markdown
Contributor

#566 creates new warning messages in the test suite. While fixing it, I noticed that the poly method was basically not used at all, even when the results are accurate enough.

This PR retains at least one system which tests the poly method.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
bnavigator added 2 commits March 17, 2021 12:28
@bnavigator
merge the second example from python-control#523 into test_stability_…
4381a7e
…margins_discrete
@bnavigator
improve error message display, ease poly to frd check
52d8fc3
@coveralls

coveralls commented Mar 17, 2021

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.02%) to 88.88% when pulling 52d8fc3 on bnavigator:add-frd-margin-test into b41574f on python-control:master.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@murrayrm
murrayrm merged commit 2500199 into python-control:master Mar 19, 2021
@murrayrm murrayrm added this to the 0.9.0 milestone Mar 20, 2021
@bnavigator
bnavigator deleted the add-frd-margin-test branch February 18, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.9.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@bnavigator @coveralls @murrayrm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.