GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — new method keyword in stability_margins and auto-fallback back to FRD .. by sawyerbfuller · Pull Request #566 · python-control/python-control

Conversation

@sawyerbfuller

@sawyerbfuller sawyerbfuller commented Mar 12, 2021

Copy link
Copy Markdown
Contributor

... when it is detected that there may be numerical inaccuracy in dt polynomial calculation.

  • this is intended to resolve numerical issue observed in DT margin calculation when there is a large difference between the size of numerator and denominator coefficients stability_margins doesn't find gain=1 crossover frequency correctly for DT systems #523. I am not sure how good the method is I used to detect this issue is any good. In fact I am sure it is not. comments welcome here.
  • can use method='poly' to override and force polynomial evaluation, or method='FRD' to force to using interpolated FRD to calculate gain and phase crossover frequencies.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@sawyerbfuller
new method keyword in stability_margins; falls back to FRD when numer…
a8a536b
…ical inaccuracy in dt polynomial calculation
@coveralls

coveralls commented Mar 12, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.06%) to 88.885% when pulling 72cb23f on sawyerbfuller:frd-margin into 0f951e1 on python-control:master.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@sawyerbfuller
impoed unit tests
94fe55e
bnavigator
bnavigator reviewed Mar 12, 2021
View reviewed changes
Comment thread control/margins.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

@bnavigator bnavigator mentioned this pull request Mar 12, 2021
support discrete system as input for FRD #568
Merged
sawyerbfuller added 4 commits March 12, 2021 13:54
@sawyerbfuller
Merge branch 'master' into frd-margin
368b0d1
@sawyerbfuller
incorporated fix enabled by github python-control#568
2b82eef
@sawyerbfuller
removed a test that was getting a different reslt on different system…
a75a3d4
…s because of numerical problems
@sawyerbfuller
relaxed tolerance
567b4db
@murrayrm

murrayrm commented Mar 13, 2021

Copy link
Copy Markdown
Member

LGTM

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@murrayrm murrayrm mentioned this pull request Mar 13, 2021
Release 0.8.4 and 0.9.0 sequencing #451
Closed
@murrayrm murrayrm linked an issue Mar 13, 2021 that may be closed by this pull request
stability_margins doesn't find gain=1 crossover frequency correctly for DT systems #523
Closed
@murrayrm murrayrm added this to the 0.9.0 milestone Mar 13, 2021
@sawyerbfuller
added warning method when falling back to frd
72cb23f
@bnavigator
bnavigator merged commit b41574f into python-control:master Mar 17, 2021
@bnavigator bnavigator mentioned this pull request Mar 17, 2021
Ease cutoff between poly and frd method for stability margins #575
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnavigator bnavigator bnavigator left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.9.0

Development

Successfully merging this pull request may close these issues.

stability_margins doesn't find gain=1 crossover frequency correctly for DT systems

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@sawyerbfuller @coveralls @murrayrm @bnavigator
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.