GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — return frequency response for 0 and 1-state systems directly by bnavigator · Pull Request #663 · python-control/python-control

Conversation

@bnavigator

@bnavigator bnavigator commented Nov 2, 2021

Copy link
Copy Markdown
Contributor

Inspired by the recent CI failures in the Slycot-less branch of the StateSpace.horner() function. Let's try to minimize this by catching simple systems early.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bnavigator
return frequency response for 0 and 1-state systems directly
433c136
@bnavigator
bnavigator marked this pull request as ready for review November 2, 2021 22:32
@bnavigator bnavigator mentioned this pull request Nov 2, 2021
new Pid design function built on sisotool #662
Merged
@bnavigator

bnavigator commented Nov 2, 2021

Copy link
Copy Markdown
Contributor Author

I tried to debug in the failure of #659, now also occuring in #662, with some debug statements in #660, but could not reliably trigger the miscalculation (compare the GHA jobs here and in the corresponding branch of the forked repo) . I suspect a broken conda environment with Py3.9/Numpy/MKL on GHA.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bnavigator

bnavigator commented Nov 2, 2021

Copy link
Copy Markdown
Contributor Author

Ah, not compatible with np.matrix.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bnavigator
only return fast in array, not matrix
5355b02
@coveralls

coveralls commented Nov 2, 2021

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.01%) to 89.935% when pulling 5355b02 on bnavigator:fast-freqresp into 5ab0a1c on python-control:master.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sawyerbfuller

sawyerbfuller commented Nov 2, 2021

Copy link
Copy Markdown
Contributor

Are you happy enough to merge this? Then I can check if it fixes the problem in #662
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bnavigator
bnavigator merged commit 42cba0c into python-control:master Nov 3, 2021
@bnavigator

bnavigator commented Nov 3, 2021

Copy link
Copy Markdown
Contributor Author

Still broken for systems with more states. :(
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bnavigator bnavigator mentioned this pull request Nov 4, 2021
np.linalg.solve broken on CI #664
Closed
@murrayrm murrayrm added this to the 0.9.1 milestone Dec 30, 2021
@bnavigator
bnavigator deleted the fast-freqresp branch February 18, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.9.1

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@bnavigator @coveralls @sawyerbfuller @murrayrm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.