GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — new Pid design function built on sisotool by sawyerbfuller · Pull Request #662 · python-control/python-control

Conversation

@sawyerbfuller

@sawyerbfuller sawyerbfuller commented Nov 2, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Provides a manual means of tuning a PID controller but does not attempt an automatic solution, thus its name pid_designer. Edit: renamed function to rootlocus_pid_designer to distinguish it from loopshaping techniques. Partially addresses #657.

Uses Sisotool to investigate the effect of adding or subtracting an
amount deltaK to the proportional, integral, or derivative (PID) gains of
a controller. One of the PID gains, Kp, Ki, or Kd, respectively, can
be modified at a time. Sisotool plots the step response, frequency
response, and root locus.

When first run, deltaK is set to 0; click on a branch of the root locus
plot to try a different value. Each click updates plots and prints
the corresponding deltaK. To tune all three PID gains, repeatedly call
pid_designer, and select a different gain each time ('P', 'I',
or 'D'). Make sure to add the resulting deltaK to your chosen initial
gain on the next iteration.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
bnavigator
bnavigator reviewed Nov 2, 2021
View reviewed changes
Comment thread control/tests/sisotool_test.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

@bnavigator

bnavigator commented Nov 2, 2021

Copy link
Copy Markdown
Contributor

Same CI failure as in #659. #663 might work around it.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bnavigator bnavigator mentioned this pull request Nov 2, 2021
return frequency response for 0 and 1-state systems directly #663
Merged
@sawyerbfuller
sawyerbfuller force-pushed the pid-designer branch from 45f3555 to fa1dea1 Compare November 4, 2021 17:28
@sawyerbfuller sawyerbfuller linked an issue Nov 4, 2021 that may be closed by this pull request
I'm having problems with the ax parameters of the rlocus function #623
Closed
@sawyerbfuller
sawyerbfuller force-pushed the pid-designer branch from 1eb9997 to b2478f2 Compare November 4, 2021 22:56
@coveralls

coveralls commented Nov 4, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.1%) to 90.077% when pulling 4ee9fd1 on sawyerbfuller:pid-designer into affe4d3 on python-control:master.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

sawyerbfuller added 10 commits November 5, 2021 14:34
@sawyerbfuller
new pid-designer, built on sisotool, for manual tuning of a PID contr…
3263646
…oller
@sawyerbfuller
attribution
c4bd384
@sawyerbfuller
changed color of root locus pole markers to black instead of randomly…
ffd7b5f
…-changing colors in sisotool
@sawyerbfuller
fixed unit test code
cd7faaa
@sawyerbfuller
renamed function to highlight that it is based on root locus, set ini…
ec0f0a8
…tial gain to 1, new noplot argument for faster testing
@sawyerbfuller
fix for github python-control#623
3dca645
@sawyerbfuller
added pointer to new function to docs
5c3e823
@sawyerbfuller
more comprehensive system construction tests
2af1171
@sawyerbfuller
return loop transfer function as statespace
746e089
@sawyerbfuller
small docstring fix
4ee9fd1
@sawyerbfuller
sawyerbfuller force-pushed the pid-designer branch from ee1aa5e to 4ee9fd1 Compare November 5, 2021 21:35
@bnavigator
bnavigator merged commit 89291e6 into python-control:master Dec 26, 2021
@murrayrm

murrayrm commented Dec 26, 2021

Copy link
Copy Markdown
Member

FYI: this is generating a bunch of warning messages. We should clean up when we get a chance.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@murrayrm murrayrm mentioned this pull request Dec 27, 2021
Fix warning messages in rootlocus_pid_designer unit tests #684
Merged
@murrayrm murrayrm added this to the 0.9.1 milestone Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnavigator bnavigator bnavigator left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.9.1

Development

Successfully merging this pull request may close these issues.

I'm having problems with the ax parameters of the rlocus function

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@sawyerbfuller @bnavigator @coveralls @murrayrm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.