GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix warning messages in rootlocus_pid_designer unit tests by murrayrm · Pull Request #684 · python-control/python-control

Conversation

@murrayrm

@murrayrm murrayrm commented Dec 27, 2021

Copy link
Copy Markdown
Member

This PR gets rid of warning messages introduced in PR #662:

  • Since rootlocus_pid_designer leaves either r or d disconnected, the interconnect function was generating warnings (76 of them...). This was fixed by using check_unused=False.
  • Calling rootlocus_pid_designer with plot=True seems to generate a Bode plot that is -1 and this creates a warning:
control/ctrlutil.py:75: RuntimeWarning: invalid value encountered in remainder
  dangle_desired = (dangle + period/2.) % period - period/2.

For now this latter problem is fixed by skipping this test.

@sawyerbfuller I'm not quite sure how to fix this error. If I try running the test by hand using

ct.rootlocus_pid_designer(syscont, input_signal='r', Kp0=0.01,
    derivative_in_feedback_path=True, gain='P')

then I get the following plot:

Sisotool_pid_designer_bug

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
murrayrm added 2 commits December 26, 2021 19:03
@murrayrm
fix warning messages in pid_designer
674f6f6
@murrayrm
skip rootlocus_pid_designer tests that are generating warnings
7cfa42a
@coveralls

coveralls commented Dec 27, 2021

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.2%) to 93.383% when pulling 7cfa42a on murrayrm:fix_pid_designer_warnings into 8356044 on python-control:master.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@murrayrm

murrayrm commented Dec 31, 2021

Copy link
Copy Markdown
Member Author

Merging this for 0.9.1, but will create an issue to track the possible bug above.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@murrayrm
murrayrm merged commit b78dcc4 into python-control:master Dec 31, 2021
@murrayrm murrayrm mentioned this pull request Dec 31, 2021
rootlocus_pid_designer plot looks strange + needs documentation #686
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@murrayrm @coveralls
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.