GeezerVison is showing github.com — Move sys._update_params(params) before TimeResponseData return when nstate == 0 by hyumo · Pull Request #774 · python-control/python-control
Conversation
hyumo
commented
Oct 3, 2022
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
It was found that for system without states, params not are updated at the right timing in the input_output_response function.
Need to move sys._update_params(params) before TimeResponseData returns if nstate == 0
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Coverage remained the same at 94.766% when pulling 8aa271d on hyumo:main into f758725 on python-control:main.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.