GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Small fixes based on Caltech CDS 112 course by murrayrm · Pull Request #849 · python-control/python-control

Conversation

@murrayrm

@murrayrm murrayrm commented Jan 14, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This PR contains some small fixes that I discovered while teaching CDS 112 at Caltech in Winter 2023:

  • Fixed bug in create_statefbk_iosystem that didn't proper handle 1D gain schedules.
  • flatsys.point_to_point generates an error if you specify a cost or constraint with less than 3 time points.
  • Sampling a LinearIOSystem returns a LinearIOSystem (before it returned a StateSpace system).
  • Added an add_unused keyword parameter to interconnect that allows unused inputs or outputs to be added as inputs or outputs of the interconnected system (useful for doing a "partial" interconnection).
  • create_mpc_iosystem now allows system and signal names to be specified via appropriate keywords.
  • Changed type keyword for create_statefbk_iosystem to controller_type (linear or nonlinear). Using type generates a deprecation warning.
  • Added control_indices and state_indices to create_statefbk_iosystem to allow partial interconnection (eg, for inner/outer loop construction).
  • Updated unit tests, docstrings, and comments.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
This was linked to issues Jan 14, 2023
The step_info() function is not documented on readthedocs #844
Closed
create_statefbk_iosystem sets system name incorrectly #848
Closed
@coveralls

coveralls commented Jan 14, 2023

Copy link
Copy Markdown

Coverage Status

Coverage: ?%. Remained the same when pulling 10bcd65 on murrayrm:cds112_fixes-12Jan2023 into 55730b6 on python-control:main.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@coveralls

coveralls commented Jan 14, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Coverage Status

Coverage: 94.876% (-0.007%) from 94.883% when pulling 574cf69 on murrayrm:cds112_fixes-12Jan2023 into 08dcc95 on python-control:main.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bnavigator
bnavigator reviewed Jan 15, 2023
View reviewed changes
Comment thread control/statefbk.py
type : 'linear' or 'nonlinear', optional
controller_type : 'linear' or 'nonlinear', optional

@bnavigator bnavigator Jan 15, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's an API change. The milestone should be 0.10.0 (or 1.0.0) then.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@murrayrm murrayrm Jan 15, 2023

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put in code to handle legacy calls, so type will still work. See line 732.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@murrayrm
murrayrm force-pushed the cds112_fixes-12Jan2023 branch from 10bcd65 to ed03726 Compare January 27, 2023 15:09
@henklaak henklaak mentioned this pull request Feb 1, 2023
Fix Interconnect name clobbering #857
Merged
@bnavigator
bnavigator force-pushed the cds112_fixes-12Jan2023 branch from ed03726 to 91c0260 Compare February 2, 2023 12:19
@bnavigator

bnavigator commented Feb 2, 2023

Copy link
Copy Markdown
Contributor

Rebased onto current main, in order to resolve conflicts due to #857
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@murrayrm
murrayrm force-pushed the cds112_fixes-12Jan2023 branch from 67ea154 to 8e40c90 Compare February 18, 2023 21:16
@murrayrm
murrayrm marked this pull request as ready for review March 13, 2023 05:55
murrayrm and others added 12 commits March 18, 2023 10:33
@murrayrm
add link to documentation for step_info
99ec022
@bnavigator @murrayrm
rename 'type' keyword
c03b771
@murrayrm
add entry for unused kwargs in create_statefbk_iosystem
cd89353
@murrayrm
require at least 3 points for point_to_point w/ cost, constraints
c90781d
@murrayrm
add support for 1D gain scheduling
dd1e2d3
@murrayrm
update integral_action docstrings (must be ndarray)
1535738
@murrayrm
add signal name kwargs for create_mpc_iosysm + kwargs testing for ct.…
1a32831 
…optimal
@murrayrm
add warning if output might not be state in create_statefbk_iosystem
20177f2
@murrayrm
charge 'horizon' to 'timepts' in solve_ocp
e1e5bc9
@murrayrm
allow passthru system inputs in create_statefbk_iosystem
867b353
@murrayrm
sampling a LinearIOSystem returns a LinearIOSystem
2fcc287
@murrayrm
small tweaks to comments, docstrings, unit tests
574cf69
@murrayrm
murrayrm force-pushed the cds112_fixes-12Jan2023 branch from 49756c4 to 574cf69 Compare March 18, 2023 17:33
@murrayrm
murrayrm merged commit 177cba9 into python-control:main Mar 24, 2023
@murrayrm
murrayrm deleted the cds112_fixes-12Jan2023 branch March 24, 2023 04:28
@murrayrm murrayrm added this to the 0.9.4 milestone Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnavigator bnavigator bnavigator left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.9.4

Development

Successfully merging this pull request may close these issues.

create_statefbk_iosystem sets system name incorrectly The step_info() function is not documented on readthedocs

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@murrayrm @coveralls @bnavigator
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.