GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix Interconnect name clobbering by henklaak · Pull Request #857 · python-control/python-control

Conversation

@henklaak

@henklaak henklaak commented Feb 1, 2023

Copy link
Copy Markdown
Contributor

iosys interconnect implementation clobbers the name argument of the function.
Fix by renaming to a name that is only used locally

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@henklaak
Fix Interconnect name clobbering
5f2e758
@henklaak

henklaak commented Feb 1, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Fixes #848

Overlap with #849, but that one doesn't come with unittests ;-)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@coveralls

coveralls commented Feb 2, 2023

Copy link
Copy Markdown

Coverage Status

Coverage: 94.87%. Remained the same when pulling 5f2e758 on henklaak:main into 1f837a5 on python-control:main.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bnavigator

bnavigator commented Feb 2, 2023

Copy link
Copy Markdown
Contributor

Thanks. Will rebase #849.
henklaak reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bnavigator
bnavigator merged commit c4d1764 into python-control:main Feb 2, 2023
This was referenced Feb 2, 2023
Small fixes based on Caltech CDS 112 course #849
Merged
create_statefbk_iosystem sets system name incorrectly #848
Closed
@bnavigator bnavigator linked an issue Feb 2, 2023 that may be closed by this pull request
create_statefbk_iosystem sets system name incorrectly #848
Closed
@murrayrm murrayrm added this to the 0.9.4 milestone Mar 27, 2023
@murrayrm murrayrm mentioned this pull request May 25, 2023
InterconnectedSystem changing the system name if signal is mistyped #897
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.9.4

Development

Successfully merging this pull request may close these issues.

create_statefbk_iosystem sets system name incorrectly

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@henklaak @coveralls @bnavigator @murrayrm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.