GeezerVison

Coverage: 94.535%. Remained the same when pulling 8b5eb47 on sawyerbfuller:static-signal-names into 1e1c8eb on python-control:main.

Found it! Losing signal names when slycot is not installed.

Working on a fix.

Found the bug and squashed it. _convert_to_statespace was not passing signal names correctly in all cases, particularly with no slycot.

@sawyerbfuller Should the system name be copied over directly or should it be modified by appending $converted or something along those lines? One reason not to change the system name is that if you use interconnect with transfer functions, it is more natural to use the same system name. But this means that you can have two objects (the original TransferFunction and a StateSpace object) both having the same name...

@murrayrm my first thought is that the private method should keep the same system name because it is being used is internally.

But maybe if the system was changed by the user using ‘ss’, then that default should be overrided and the system should get a new name. sys$converted?

I like the idea of having "$converted" appended when you do an explicit conversion (eg, via ss applied to a TransferFunction). That way you don't end up with two explicit objects floating around that have the same name but aren't the same object.

If we do that, we should probably generate a utility function/method that renames objects, probably in namedio.py so that we get some uniformity (including use of prefix and/or suffix, setting configuration defaults, etc). That goes beyond this PR, so could be split off as a separate issue?

HI @murrayrm that sounds good. Yes there are a few issues surrounding when to add $converted that may be outside of scope for this PR. E.g. if you call LinearIOSystem on a StateSpace system, does that get a suffix? if you call ss on a system, what method is responsible for adding $converted.

For this PR, OK if we leave it as it is, with _convert_to_statespace not changing the name? This is what you want when you are interconnecting TransferFunction and StateSpace objects and the former are being converted internally.