GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Change name of converted LinearIOSystems by murrayrm · Pull Request #903 · python-control/python-control

Conversation

@murrayrm

@murrayrm murrayrm commented Jun 4, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This PR implements that change suggested in PR #884 and issue #901 regarding changing the system name when a transfer function is converted to a state space system and vice versa. Converted systems now have "$converted" appended to the system name. This is only done when you do an explicit conversation via ss or tf. Implicit conversions from a TransferFunction to a StateSpace object, for example as part of using interconnect use the original name.

In addition, prefix/suffix processing has been moved into the NamedIOSystem class, under _copy_names and _name_or_default methods.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
murrayrm added 5 commits June 3, 2023 14:26
@murrayrm
consolidate system name prefix/suffix updates to namedio.sys
0b5e3fa
@murrayrm
change system name when converting tf to ss
37243f6
@murrayrm
change system name when converting ss to tf
0530b52
@murrayrm
add unit test to make sure implicit tf -> ss conversion keeps name
e25ad67
@murrayrm
fix up no Slycot case that was failing unit tests
d32a3db
@murrayrm
murrayrm requested a review from sawyerbfuller June 4, 2023 15:48
@murrayrm murrayrm linked an issue Jun 4, 2023 that may be closed by this pull request
Add rename system method to NamedIOSystems #901
Closed
@coveralls

coveralls commented Jun 4, 2023

Copy link
Copy Markdown

Coverage Status

coverage: 94.628% (+0.005%) from 94.623% when pulling d32a3db on murrayrm:namedio-03Jun2023 into 184d83d on python-control:main.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sawyerbfuller
sawyerbfuller approved these changes Jun 5, 2023
View reviewed changes

@sawyerbfuller sawyerbfuller left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new method, _copy_names is something I have needed on a few different occasions and will put to use. This looks like a good solution.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@murrayrm
murrayrm merged commit 3435304 into python-control:main Jun 6, 2023
@murrayrm murrayrm added this to the 0.9.4 milestone Jun 7, 2023
@murrayrm murrayrm mentioned this pull request Jun 8, 2023
fix up some warning messages due to converted systems #907
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sawyerbfuller sawyerbfuller sawyerbfuller approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.9.4

Development

Successfully merging this pull request may close these issues.

Add rename system method to NamedIOSystems

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@murrayrm @coveralls @sawyerbfuller
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.