GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix up some warning messages due to converted systems by murrayrm · Pull Request #907 · python-control/python-control

Conversation

@murrayrm

@murrayrm murrayrm commented Jun 8, 2023

Copy link
Copy Markdown
Member

Small PR to fix up some issues where the functionality in #903 was causing some warning messages. In particular, the following snipped was causing a warning (from matlab_test.py):

siso_tf2 = tf([1, 1], [1, 2, 3, 1])
siso_ss2 = ss(siso_tf2)
[gm, pm, gmc, pmc] = margin(siso_ss2 * siso_ss2 * 2)

The reason for the warning was that siso_ss2 had the name 'sys[0]$converted' and when you create an interconnected system with duplicated non-generic names it gives you a warning (since things like change the parameters of one of the systems would affect the other.

To fix this, converted LinearIOSystems with "generic" names (sys[0]) do not get '$converted' added to the end. Instead they just get a new generic system name.

That change meant that some of the previous unit tests needed to use an explicitly named system, which is what the the changes in the unit tests are about.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@murrayrm
fix up some warning messages due to converted systems
fb7a4a5
@murrayrm murrayrm added this to the 0.9.4 milestone Jun 8, 2023
@coveralls

coveralls commented Jun 8, 2023

Copy link
Copy Markdown

Coverage Status

coverage: 94.628%. remained the same when pulling fb7a4a5 on murrayrm:fix_warnings-07Jun2023 into d834f7a on python-control:main.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@murrayrm
murrayrm merged commit 56b9402 into python-control:main Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.9.4

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@murrayrm @coveralls
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.