GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||||||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||||||||||||||||||||||||||||||
GeezerVison is showing github.com — Update pole/zero and root locus plots to use _map/_plot pattern by murrayrm · Pull Request #953 · python-control/python-control Conversation
|
|
coverage: 94.866% (-0.1%) from 94.989% |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
| import numpy as np | ||
| import matplotlib.pyplot as plt | ||
| import warnings | ||
| from functools import partial |
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Worth running this through isort?
warnings and functools are stdlib, Numpy and Pyplot external.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
| # Legacy return format | ||
| with pytest.warns(DeprecationWarning, match=".* values .* deprecated"): | ||
| poles, zeros = ct.pole_zero_plot(pzdata, plot=False) | ||
| np.testing.assert_equal(poles, sys.poles()) | ||
| np.testing.assert_equal(zeros, sys.zeros()) | ||
|
|
||
| with pytest.warns(DeprecationWarning, match=".* values .* deprecated"): | ||
| poles, zeros = ct.pole_zero_plot(pzdata, plot=True) | ||
| np.testing.assert_equal(poles, sys.poles()) | ||
| np.testing.assert_equal(zeros, sys.zeros()) |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Parametrize?
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
This is large, without too extensive review, I would say LGTM.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.