GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix CI warnings by murrayrm · Pull Request #955 · python-control/python-control

Conversation

@murrayrm

@murrayrm murrayrm commented Dec 29, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This PR makes a bunch of small changes to remove warning messages in the GitHub actions CI runs:

  • Access scalar NumPy arrays using item() (old usage is newly deprecated in NumPy).
  • Change set_tight_layout(True) to fig.set_layout_engine('tight') (newly deprecated in Matplotlib).
  • Update unit tests using deprecated functionality to use current functionality.
  • Add warning filters for internal calls to connect (which are OK for now).
  • Avoid calling tf2zpk with zero in the numerator (SciPy generates warning).
  • Fix up some strings that had newly deprecated escape sequences (by using raw strings)
  • Turn off warnings for optimal control problems that fail to hit desired precision (but still return valid answers)

Note: it is likely that this PR will conflict with #953. We should probably merge #953 first and then rebase this PR since the changes here are pretty straightforward.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
murrayrm added 3 commits December 29, 2023 11:35
@murrayrm
small changes to fix pytest warnings on py3.11
af6e14b
@murrayrm
update code/tests to remove expected warnings
cfccc28
@murrayrm
additional fixes for github actions warnings
76dee0d
@coveralls

coveralls commented Dec 30, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Coverage Status

coverage: 94.78% (-0.09%) from 94.866%
when pulling dc74493 on murrayrm:fixwarnings-23Dec2023
into eb0f3f9 on python-control:main.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
slivingston
slivingston reviewed Dec 30, 2023
View reviewed changes
Comment thread control/xferfcn.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@murrayrm
fix typo pointed out by @slivingston
dc74493
@murrayrm murrayrm added this to the 0.10.0 milestone Dec 30, 2023
@bnavigator

bnavigator commented Jan 10, 2024

Copy link
Copy Markdown
Contributor

Note: it is likely that this PR will conflict with #953. We should probably merge #953 first and then rebase this PR since the changes here are pretty straightforward.

Either this or the other way round. Python 3.12 requires numpy 1.26 on conda, already triggering the deprecation warnings. I had to disable them for the Slycot CI: https://github.com/python-control/Slycot/pull/227/files#diff-b2cf1d5b6cad7a0f6a749da416cb8a4e34040b2164a84a651783692d4b60d608R17
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@murrayrm

murrayrm commented Jan 12, 2024

Copy link
Copy Markdown
Member Author

Looks like there were no conflicts, so going ahead and merging.

@bnavigator: FYI (and not really for this PR), I tried updating GitHub actions to use Python 3.12 but mamba caused problems, so I'm waiting until that clears. You can find the attempt here.
bnavigator reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@murrayrm murrayrm closed this Jan 12, 2024
@murrayrm murrayrm reopened this Jan 12, 2024
@murrayrm
murrayrm merged commit 9509dfd into python-control:main Jan 12, 2024
@murrayrm
murrayrm deleted the fixwarnings-23Dec2023 branch January 12, 2024 05:35
@bnavigator bnavigator mentioned this pull request Jan 12, 2024
Support Python 3.12, Bump minimum support according to SPEC 0 #961
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slivingston slivingston slivingston left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.10.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@murrayrm @coveralls @bnavigator @slivingston
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.