GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix docstring for root_locus_map by bnavigator · Pull Request #988 · python-control/python-control

Conversation

@bnavigator

@bnavigator bnavigator commented Apr 3, 2024

Copy link
Copy Markdown
Contributor

Fixes #987

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bnavigator
Fix docstring
a0e5ea7 
Fixes python-controlgh-987
@bnavigator bnavigator mentioned this pull request Apr 3, 2024
Wrong parameter name in documentation #987
Closed
@coveralls

coveralls commented Apr 3, 2024

Copy link
Copy Markdown

Coverage Status

coverage: 94.482%. remained the same
when pulling a0e5ea7 on bnavigator:fix-987
into 1b2abe3 on python-control:main.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@slivingston

slivingston commented Apr 3, 2024

Copy link
Copy Markdown
Member

kvect also appears earlier in the same docstring. Can you fix that, too?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@murrayrm
murrayrm merged commit c638362 into python-control:main Apr 3, 2024
@murrayrm murrayrm added this to the 0.10.1 milestone Apr 3, 2024
@bnavigator

bnavigator commented Apr 3, 2024

Copy link
Copy Markdown
Contributor Author

kvect also appears earlier in the same docstring. Can you fix that, too?

Too late 🙈
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@slivingston

slivingston commented Apr 3, 2024

Copy link
Copy Markdown
Member

I'll get it next time :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@murrayrm murrayrm mentioned this pull request Apr 5, 2024
Update documentation, processing of root_locus kvect keyword #989
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.10.1

Development

Successfully merging this pull request may close these issues.

Wrong parameter name in documentation

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@bnavigator @coveralls @slivingston @murrayrm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.