GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Update documentation, processing of root_locus kvect keyword by murrayrm · Pull Request #989 · python-control/python-control

Conversation

@murrayrm

@murrayrm murrayrm commented Apr 5, 2024

Copy link
Copy Markdown
Member

This PR addresses issue #987, which was partially fixed in #988, by consistently using the keyword gains instead of kvect in the root locus commands. In addition, if the kvect keyword is used, a warning is generated indicating that kvect has been deprecated and gains should be used instead.

Also include some minor reformatting of docstrings in rlocus.py.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@murrayrm
update documentation, processing of root_locus kvect keyword
a9415a0
@coveralls

coveralls commented Apr 5, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Coverage Status

coverage: 94.482%. remained the same
when pulling 1b59bd6 on murrayrm:update_rlocus_kvect-04Apr2024
into c638362 on python-control:main.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bnavigator
bnavigator reviewed Apr 5, 2024
View reviewed changes
Comment thread control/rlocus.py Outdated
kvect keyword argument if provided).
(legacy) If the `plot` keyword is given, returns the closed-loop
root locations, arranged such that each row corresponds to a gain
in gains, and the array of gains (ame as gains keyword argument if

@bnavigator bnavigator Apr 5, 2024

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
in gains, and the array of gains (ame as gains keyword argument if
in gains, and the array of gains (same as `gains` keyword argument if

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
slivingston
slivingston approved these changes Apr 6, 2024
View reviewed changes

@slivingston slivingston left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to merge, except for the misprint identified by @bnavigator (the misprint existed before this PR, but might as well fix it).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@murrayrm
fix typo identified by @bnavigator
1b59bd6
@murrayrm
murrayrm merged commit 49f03e7 into python-control:main Apr 6, 2024
@murrayrm murrayrm added this to the 0.10.1 milestone Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnavigator bnavigator bnavigator left review comments
@slivingston slivingston slivingston approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.10.1

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@murrayrm @coveralls @slivingston @bnavigator
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.