GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Use `pyproject.toml` instead of `setup.py` and `setup.cfg` where possible · Issue #356 · python-graphblas/python-graphblas

Use pyproject.toml instead of setup.py and setup.cfg where possible #356

New issue
Copy link
New issue
Copy link
Closed
#366
Closed
Use pyproject.toml instead of setup.py and setup.cfg where possible#356
#366
Copy link
Assignees
eriknw
Labels
good first issueClearly described and easy to accomplish. Good for beginners to the project.Clearly described and easy to accomplish. Good for beginners to the project.hygieneImprove code quality and reduce maintenance overheadImprove code quality and reduce maintenance overhead

Description

@eriknw
eriknw
opened on Dec 30, 2022
Issue body actions

Let's become more modern and update to use pyproject.toml instead of setup.py and setup.cfg. We'll probably still need setup.cfg, but let's move as much as we can to pyproject.toml.

We should also see if we can move other configuration such as .readthedocs.yml and .codecov.yml to pyproject.toml.

This relates mostly to PEP 621, and also to PEPs 518, 517, 660, and maybe others:

  • https://peps.python.org/pep-0621/
  • https://peps.python.org/pep-0518/
  • https://peps.python.org/pep-0517/
  • https://peps.python.org/pep-0660/

I labeled this as a "good first issue" if you're knowledgeable about such things or want to learn about it, since it's mostly about moving metadata from one format to another. This is a useful skill that I'm sure could be applied to many other projects as well!

These PEPs are largely about tooling for building packages and making metadata less programmatic. Since python-graphblas is pure Python and our releases, builds, and uploads are automated, we don't need to care that much about build tooling. What we care about with this is updating and centralizing metadata (i.e., PEP 621).

More context:

  • https://www.shore.co.il/blog/pep-621-and-setuptools/
  • http://ivory.idyll.org/blog/2021-transition-to-pyproject.toml-example.html
  • https://snarky.ca/what-the-heck-is-pyproject-toml/

Activity

  1. eriknw
    added
    good first issueClearly described and easy to accomplish. Good for beginners to the project.Clearly described and easy to accomplish. Good for beginners to the project.
    hygieneImprove code quality and reduce maintenance overheadImprove code quality and reduce maintenance overhead
    on Dec 30, 2022
  2. eriknw
    added 2 commits that reference this issue on Jan 5, 2023

    Move more config to pyproject.toml (see python-graphblas#356)

    568cd86

    Computation between scalars (#358)

    501fe6f
  3. eriknw
    self-assigned this
    on Jan 18, 2023
  4. eriknw commented on Jan 18, 2023

    @eriknw
    eriknw
    on Jan 18, 2023
    MemberAuthor
    More actions

    I moved everything over to pyproject.toml in #366. We should probably do a beta release to verify everything works as expected.

    flake8 still uses setup.cfg (for reasons), and codecov and readthedocs still user their own config files (b/c they support more language than just Python and don't want to look in pyproject.toml for some reason).

    Build-tool-wise, we still use setuptools, which I think is fine.

  5. eriknw
    closed this as completedin #366on Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

  • @eriknw
    eriknw

Labels

good first issueClearly described and easy to accomplish. Good for beginners to the project.Clearly described and easy to accomplish. Good for beginners to the project.hygieneImprove code quality and reduce maintenance overheadImprove code quality and reduce maintenance overhead

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

    You are visitor 01402503 — GeezerVison does not store the pages you look up.
    Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.