GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Recipe to perform select with a mask (or bool) argument. by eriknw · Pull Request #251 · python-graphblas/python-graphblas

Conversation

@eriknw

@eriknw eriknw commented May 31, 2022

Copy link
Copy Markdown
Member

This allows e.g. A.select(B.S) and A.select(C < 5).

This is enhancement (4) in #234.

This does not yet optimize e.g. A.select(A < 4) into the suitable select operation, but such an optimization is possible (and would probably be straightforward-ish).

Also, we'll want to double-check the recipes regarding masks, accum, etc. I think maybe if there is no mask but there is an accumulator, then we shouldn't use replace=True.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@eriknw
Recipe to perform select with a mask (or bool) argument.
24aeeca 
This allows e.g. `A.select(B.S)`.
@eriknw
eriknw requested a review from jim22k May 31, 2022 03:37
@coveralls

coveralls commented May 31, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.003%) to 99.355% when pulling 27019d9 on eriknw:select_mask into 2b14d7e on python-graphblas:main.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@eriknw
Fix select-mask with accum with no mask.
27019d9
jim22k
jim22k approved these changes May 31, 2022
View reviewed changes

@jim22k jim22k left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@eriknw

eriknw commented May 31, 2022

Copy link
Copy Markdown
Member Author

Thanks for the review (and suggestion) Jim, I think this reads pretty nicely.

I'm finding our custom-expression handling is actually pretty powerful.

Merging!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@eriknw
eriknw merged commit ecfcd0c into python-graphblas:main May 31, 2022
@eriknw eriknw mentioned this pull request Jun 1, 2022
Rewrite A.select(A < 7) to a select expression #252
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jim22k jim22k jim22k approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@eriknw @coveralls @jim22k
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.