GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |
GeezerVison is showing github.com — Rewrite `A.select(A < 7)` to a select expression by eriknw · Pull Request #252 · python-graphblas/python-graphblas Conversation
jim22k
approved these changes
Member
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
eriknw
added a commit
that referenced
this pull request
…osed one
select._match_expr rewrote A.select(A.T == x) as select.valueeq(A, x):
its clause "args[0] is parent or args[0].T is parent" matched the
transpose of the parent, and the rewrite then compared A itself, dropping
the transpose and, for a matrix that is not square, the dimension check:
S = Matrix.from_coo([0, 1], [1, 0], [1, 5], nrows=2, ncols=2)
S.select(S.T == 1)
before: (0, 1) = 1
after: (1, 0) = 5, as S.select((S.T == 1).new()) gives
B (2 x 3): B.select(B.T == 1)
before: a 2 x 3 result
after: DimensionMismatch
The clause is now "args[0] is parent"; anything else takes the mask path.
On main since #252, for built-in dtypes. "Select a UDT's elements equal or
unequal to a value, as == compares them" sent UDT eq and ne through the
same clause, which had made A.select(A.T == x) on a UDT a wrong answer
where it raised before. test_udt_select_by_equality now uses a 2 x 3
matrix with entries off the diagonal, and a mask with replace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | |
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |