GeezerVisonThe World Wide Web, restored to 800 pixels of glory. |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites |
GeezerVison is showing github.com — Hold the owner of a borrowed GraphBLAS handle in TypedOpBase by eriknw · Pull Request #587 · python-graphblas/python-graphblas Conversation
Member
The result is a dangling pointer rather than a NULL one. Reproduced at 6f1eb02: Whether it raises depends on whether anything happens to retain the Replace the per-instance opt-out with Stack created with GitHub Stacks CLI • Give Feedback 💬
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
eriknw
marked this pull request as ready for review
eriknw
force-pushed
the
07-selectop-borrowed-handle-lifetime
branch
from
5c6a883 to
62aa452
Compare
eriknw
force-pushed
the
07-selectop-borrowed-handle-lifetime
branch
2 times, most recently
from
011d167 to
bdfc46d
Compare
eriknw
force-pushed
the
07-selectop-borrowed-handle-lifetime
branch
from
bdfc46d to
99a59d4
Compare
eriknw
force-pushed
the
07-selectop-borrowed-handle-lifetime
branch
from
99a59d4 to
67a9305
Compare
eriknw
force-pushed
the
07-selectop-borrowed-handle-lifetime
branch
from
67a9305 to
1c41f2b
Compare
eriknw
force-pushed
the
07-selectop-borrowed-handle-lifetime
branch
from
1c41f2b to
cfb2cb7
Compare
eriknw
force-pushed
the
07-selectop-borrowed-handle-lifetime
branch
from
cfb2cb7 to
886374b
Compare
eriknw
force-pushed
the
07-selectop-borrowed-handle-lifetime
branch
from
886374b to
0eff3f4
Compare
eriknw
changed the base branch from
42-arm-pickle3-numpy1-skip
to
43-ci-local-rng
eriknw
force-pushed
the
07-selectop-borrowed-handle-lifetime
branch
from
0eff3f4 to
e1d701a
Compare
eriknw
force-pushed
the
07-selectop-borrowed-handle-lifetime
branch
from
e1d701a to
092ab62
Compare
eriknw
force-pushed
the
07-selectop-borrowed-handle-lifetime
branch
from
092ab62 to
252c82c
Compare
eriknw
force-pushed
the
07-selectop-borrowed-handle-lifetime
branch
from
252c82c to
22af6b1
Compare
eriknw
force-pushed
the
07-selectop-borrowed-handle-lifetime
branch
from
22af6b1 to
4f0dabb
Compare
This was referenced
`SelectOp._from_indexunary` reuses the IndexUnaryOp's `GrB_IndexUnaryOp`
rather than allocating a second one, and marked the borrowing typed op
`_owns_gb_obj_inst = False` so that only one side would free it. Nothing
kept the owner alive, though: `register_anonymous` drops the IndexUnaryOp
on the way out, so its typed op is collected and frees the handle while the
SelectOp is still pointing at it.
The result is a dangling pointer rather than a NULL one. `__del__` frees
through a synthesized cell, `ffi.new(f"{c_type_name}*", gb_obj)`, so
`GrB_*_free` clears that temporary and leaves the op's own `gb_obj` holding
the old address.
Reproduced at 6f1eb02:
def _ne_thunk(x, i, j, thunk):
return x != thunk
sel = SelectOp.register_anonymous(_ne_thunk)
gc.collect()
Vector.from_coo([0, 1, 2], [1, 5, 9]).select(sel, 5).new()
-> UninitializedObject
Whether it raises depends on whether anything happens to retain the
IndexUnaryOp. With `x > thunk` it survives, because a traceback caught
inside the per-dtype compile loop keeps a frame that references it.
Replace the per-instance opt-out with `_gb_obj_owner`, naming the owning
typed op. That suppresses our free and keeps the handle alive for as long
as we can reach it; disclaiming ownership without naming an owner is what
left the handle dangling. The opt-out being replaced was added in 6f1eb02
to stop a double free, so the sequence is leak, double free, opt-out,
dangling handle, and now an owned reference.
eriknw
force-pushed
the
07-selectop-borrowed-handle-lifetime
branch
from
01245a0 to
249a147
Compare
Read on its own, `_owns_gb_obj = True` says every TypedUserSelectOp frees its handle. The ones `_from_indexunary` builds do not: they borrow the IndexUnaryOp's `GrB_IndexUnaryOp` and set `_gb_obj_owner`, which suppresses the free. Worth a comment because the mistake is silent. Freeing from both sides is a use-after-free, and a freed handle usually still reads as valid: with the ownership removed, select kept returning correct results even after 30 fresh allocations churned the allocator. No test would catch it. Uh oh!
There was an error while loading. Please reload this page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersNo reviewsUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. |
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |