GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — parse_pcap_klap: require source host by rytilahti · Pull Request #1137 · python-kasa/python-kasa

Conversation

@rytilahti

@rytilahti rytilahti commented Sep 28, 2024

Copy link
Copy Markdown
Member

The current logic does not accommodate when multiple hosts are communicating with the target device.
This adds a mandatory --source-host to make sure the correct handshake is captured.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@rytilahti
parse_pcap_klap: require source host
e686bb9 
The current logic does not accommodate when multiple hosts are
communicating with the target device.
This adds a mandatory --source-host to make sure the correct handshake
is captured.
@rytilahti rytilahti added the bug Something isn't working label Sep 28, 2024
@rytilahti
rytilahti requested a review from sdb9696 September 28, 2024 13:34
@rytilahti
Fix linting
7cb3b00
@codecov

codecov Bot commented Sep 28, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.59%. Comparing base (130e1b6) to head (5c75c7f).
Report is 197 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1137   +/-   ##
=======================================
  Coverage   92.59%   92.59%           
=======================================
  Files          96       96           
  Lines        6103     6103           
  Branches     1511     1511           
=======================================
  Hits         5651     5651           
  Misses        354      354           
  Partials       98       98

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sdb9696

sdb9696 commented Sep 28, 2024

Copy link
Copy Markdown
Contributor

What other hosts are communicating with the target? Are you communicating directly with a hub connected device and the hub is also talking to it?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sdb9696
sdb9696 approved these changes Sep 28, 2024
View reviewed changes
@rytilahti

rytilahti commented Sep 28, 2024

Copy link
Copy Markdown
Member Author

Both homeassistant and my mobile were talking to it, and the first handshake was done by homeassistant. The hub itself was handshaking with other devices for which I had created test automations.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rytilahti rytilahti mentioned this pull request Sep 28, 2024
Enable ruff check for ANN #1139
Merged
@sdb9696
Merge remote-tracking branch 'upstream/master' into fix/parse_klap_sr…
5c75c7f 
…c_host
@sdb9696

sdb9696 commented Sep 30, 2024

Copy link
Copy Markdown
Contributor

Rebasing and merging this as I'm going to try to use it today
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sdb9696
sdb9696 merged commit db80c38 into master Sep 30, 2024
@sdb9696
sdb9696 deleted the fix/parse_klap_src_host branch September 30, 2024 08:15
@sdb9696 sdb9696 mentioned this pull request Oct 8, 2024
Prepare 0.7.5 #1160
Merged
sdb9696 added a commit that referenced this pull request Oct 8, 2024
@sdb9696
Prepare 0.7.5 (#1160)
885a04d 
## [0.7.5](https://github.com/python-kasa/python-kasa/tree/0.7.5) (2024-10-08)

[Full Changelog](0.7.4...0.7.5)

**Release summary:**

- Fix for KP303 on Firmware 1.0.6
- Fix for `on_since` value jitter
- Various maintenance items

**Breaking changes:**

- Make iot time timezone aware [\#1147](#1147) (@sdb9696)

**Fixed bugs:**

- Use tzinfo in time constructor instead of astime for iot devices [\#1158](#1158) (@sdb9696)
- Send empty dictionary instead of null for iot queries [\#1145](#1145) (@sdb9696)
- Stabilise on\_since value for smart devices [\#1144](#1144) (@sdb9696)
- parse\_pcap\_klap: require source host [\#1137](#1137) (@rytilahti)
- parse\_pcap\_klap: use request\_uri for matching the response [\#1136](#1136) (@rytilahti)


**Project maintenance:**

- Cache zoneinfo for smart devices [\#1156](#1156) (@sdb9696)
- Correctly define SmartModule.call as an async function [\#1148](#1148) (@sdb9696)
- Remove async magic patch from tests [\#1146](#1146) (@sdb9696)
- Move feature initialization from \_\_init\_\_ to \_initialize\_features [\#1140](#1140) (@rytilahti)
pillarsdotnet pushed a commit to pillarsdotnet/python-kasa that referenced this pull request Oct 22, 2026
@rytilahti
parse_pcap_klap: require source host (python-kasa#1137)
6c1b4f4 
Adds a mandatory `--source-host` to make sure the correct handshake
is captured when multiple hosts are communicating with the target device.
pillarsdotnet pushed a commit to pillarsdotnet/python-kasa that referenced this pull request Oct 22, 2026
@sdb9696
Prepare 0.7.5 (python-kasa#1160)
aac31cd 
## [0.7.5](https://github.com/python-kasa/python-kasa/tree/0.7.5) (2024-10-08)

[Full Changelog](python-kasa/python-kasa@0.7.4...0.7.5)

**Release summary:**

- Fix for KP303 on Firmware 1.0.6
- Fix for `on_since` value jitter
- Various maintenance items

**Breaking changes:**

- Make iot time timezone aware [\python-kasa#1147](python-kasa#1147) (@sdb9696)

**Fixed bugs:**

- Use tzinfo in time constructor instead of astime for iot devices [\python-kasa#1158](python-kasa#1158) (@sdb9696)
- Send empty dictionary instead of null for iot queries [\python-kasa#1145](python-kasa#1145) (@sdb9696)
- Stabilise on\_since value for smart devices [\python-kasa#1144](python-kasa#1144) (@sdb9696)
- parse\_pcap\_klap: require source host [\python-kasa#1137](python-kasa#1137) (@rytilahti)
- parse\_pcap\_klap: use request\_uri for matching the response [\python-kasa#1136](python-kasa#1136) (@rytilahti)


**Project maintenance:**

- Cache zoneinfo for smart devices [\python-kasa#1156](python-kasa#1156) (@sdb9696)
- Correctly define SmartModule.call as an async function [\python-kasa#1148](python-kasa#1148) (@sdb9696)
- Remove async magic patch from tests [\python-kasa#1146](python-kasa#1146) (@sdb9696)
- Move feature initialization from \_\_init\_\_ to \_initialize\_features [\python-kasa#1140](python-kasa#1140) (@rytilahti)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sdb9696 sdb9696 sdb9696 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@rytilahti @sdb9696
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.