GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix update errors on hubs with unsupported children by sdb9696 · Pull Request #1344 · python-kasa/python-kasa

Conversation

@sdb9696

@sdb9696 sdb9696 commented Dec 6, 2024

Copy link
Copy Markdown
Contributor

Fixes issue mentioned in comments in issue #1341 (comment)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sdb9696
Fix update errors on hubs with child smartcams
b3eb865
@codecov

codecov Bot commented Dec 6, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 92.12%. Comparing base (8814d94) to head (bccb501).
Report is 131 commits behind head on master.

Files with missing lines Patch % Lines
kasa/smart/smartdevice.py 40.00% 2 Missing and 1 partial ⚠️
kasa/smartcam/smartcamdevice.py 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1344      +/-   ##
==========================================
- Coverage   92.18%   92.12%   -0.06%     
==========================================
  Files         120      120              
  Lines        7751     7759       +8     
  Branches      805      807       +2     
==========================================
+ Hits         7145     7148       +3     
- Misses        445      448       +3     
- Partials      161      163       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sdb9696 sdb9696 added this to the 0.8.1 milestone Dec 6, 2024
@sdb9696 sdb9696 added the bug Something isn't working label Dec 6, 2024
rytilahti
rytilahti approved these changes Dec 6, 2024
View reviewed changes
@sdb9696 sdb9696 changed the title Fix update errors on hubs with child smartcams Fix update errors on smartcam hubs with unsupported child devices Dec 6, 2024
@sdb9696 sdb9696 changed the title Fix update errors on smartcam hubs with unsupported child devices Fix update errors on smartcam hubs with unsupported children Dec 6, 2024
@sdb9696
Ensure same for smart hubs
bccb501
@sdb9696 sdb9696 changed the title Fix update errors on smartcam hubs with unsupported children Fix update errors on hubs with unsupported children Dec 6, 2024
rytilahti
rytilahti approved these changes Dec 6, 2024
View reviewed changes
@sdb9696
sdb9696 merged commit be8b713 into master Dec 6, 2024
@sdb9696
sdb9696 deleted the fix/child_smartcam branch December 6, 2024 11:01
sdb9696 added a commit that referenced this pull request Dec 6, 2024
@sdb9696
Fix update errors on hubs with unsupported children (#1344)
5465b66
@sdb9696 sdb9696 mentioned this pull request Dec 6, 2024
0.8.1 #1345
Merged
sdb9696 added a commit that referenced this pull request Dec 6, 2024
@sdb9696
0.8.1 (#1345)
611cd66 
## [0.8.1](https://github.com/python-kasa/python-kasa/tree/0.8.1) (2024-12-06)

This patch release fixes some issues with newly supported smartcam devices.

[Full Changelog](0.8.0...0.8.1)

**Fixed bugs:**

- Fix update errors on hubs with unsupported children [\#1344](#1344) (@sdb9696)
- Fix smartcam missing device id [\#1343](#1343) (@sdb9696)
rytilahti pushed a commit to rytilahti/python-kasa that referenced this pull request Aug 31, 2025
@sdb9696 @rytilahti
Fix update errors on hubs with unsupported children (python-kasa#1344)
4f52059
rytilahti pushed a commit to rytilahti/python-kasa that referenced this pull request Oct 26, 2025
@sdb9696 @rytilahti
Fix update errors on hubs with unsupported children (python-kasa#1344)
77cf736
rytilahti pushed a commit to rytilahti/python-kasa that referenced this pull request Nov 10, 2025
@sdb9696 @rytilahti
Fix update errors on hubs with unsupported children (python-kasa#1344)
6842c18
rytilahti pushed a commit to rytilahti/python-kasa that referenced this pull request Jul 5, 2026
@sdb9696 @rytilahti
Fix update errors on hubs with unsupported children (python-kasa#1344)
9d1a615
pillarsdotnet pushed a commit to pillarsdotnet/python-kasa that referenced this pull request Oct 22, 2026
@sdb9696
Fix update errors on hubs with unsupported children (python-kasa#1344)
7431eef
pillarsdotnet pushed a commit to pillarsdotnet/python-kasa that referenced this pull request Oct 22, 2026
@sdb9696
Fix update errors on hubs with unsupported children (python-kasa#1344)
caead73
pillarsdotnet pushed a commit to pillarsdotnet/python-kasa that referenced this pull request Oct 22, 2026
@sdb9696
0.8.1 (python-kasa#1345)
f856355 
## [0.8.1](https://github.com/python-kasa/python-kasa/tree/0.8.1) (2024-12-06)

This patch release fixes some issues with newly supported smartcam devices.

[Full Changelog](python-kasa/python-kasa@0.8.0...0.8.1)

**Fixed bugs:**

- Fix update errors on hubs with unsupported children [\python-kasa#1344](python-kasa#1344) (@sdb9696)
- Fix smartcam missing device id [\python-kasa#1343](python-kasa#1343) (@sdb9696)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rytilahti rytilahti rytilahti approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

0.8.1

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@sdb9696 @rytilahti
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.