GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Update dump_devinfo for raw discovery json and common redactors by sdb9696 · Pull Request #1358 · python-kasa/python-kasa

Conversation

@sdb9696

@sdb9696 sdb9696 commented Dec 9, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Depends on #1342

This PR does a few related things to dump_devinfo:

  • Store the raw discovery result in the fixture.
  • Consolidate redaction logic so it's not duplicated in dump_devinfo.
  • Update existing fixtures to:
    • Store raw discovery result under result
    • Use SCRUBBED_CHILD_DEVICE_ID everywhere
    • Have correct values as per the consolidated redactors.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
sdb9696 added 9 commits December 5, 2024 18:46
@sdb9696
Return raw discovery result in cli discover raw
1d4bd9b
@sdb9696
Fix tests
db25aad
@sdb9696
Add redaction
f1c568e
@sdb9696
Add tests
bde256e
@sdb9696
Merge branch 'master' into feat/discover_json
b57aae8
@sdb9696
Update fixtures with raw disco result format and common redaction
335b3ca
@sdb9696
Fix tests
0833c4b
@sdb9696
Update post review
c2971e6
@sdb9696
Merge remote-tracking branch 'upstream/master' into feat/discover_json
b395f4b
@sdb9696
sdb9696 changed the base branch from master to feat/discover_json December 9, 2024 15:58
sdb9696 added 4 commits December 9, 2024 15:59
@sdb9696
Merge branch 'feat/discover_json' into janitor/dump_devinfo_raw
c429f3c
@sdb9696
Update after merge and redact discovery info
c961241
@sdb9696
Fix test
606348d
@sdb9696
Merge branch 'feat/discover_json' into janitor/dump_devinfo_raw
41b9bf3
@sdb9696 sdb9696 added the maintenance Project improvements and maintenance label Dec 9, 2024
sdb9696
sdb9696 commented Dec 9, 2024
View reviewed changes
Comment thread kasa/protocols/smartprotocol.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

@sdb9696
Remove left behind extra check in mask_mac
f43e10c
@sdb9696
sdb9696 marked this pull request as ready for review December 9, 2024 17:04
@sdb9696
Add decrypted data to discovery_result
2686dc9
@codecov

codecov Bot commented Dec 9, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.17%. Comparing base (032cd5d) to head (4508c7c).
Report is 116 commits behind head on master.

Files with missing lines Patch % Lines
kasa/protocols/iotprotocol.py 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1358   +/-   ##
=======================================
  Coverage   92.17%   92.17%           
=======================================
  Files         123      123           
  Lines        7913     7926   +13     
  Branches      812      814    +2     
=======================================
+ Hits         7294     7306   +12     
  Misses        454      454           
- Partials      165      166    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

sdb9696 added 2 commits December 10, 2024 08:39
@sdb9696
Merge remote-tracking branch 'upstream/master' into janitor/dump_devi…
451e362
…nfo_raw
@sdb9696
Update newly added fixtures
0b72773
Base automatically changed from feat/discover_json to master December 10, 2024 22:42
@sdb9696
Merge remote-tracking branch 'upstream/master' into janitor/dump_devi…
c90a6f6
…nfo_raw
@sdb9696
sdb9696 requested a review from rytilahti December 11, 2024 09:59
@sdb9696 sdb9696 added this to the 0.9.0 milestone Dec 11, 2024
@sdb9696
Fix raw discover with no host
8307a88
rytilahti
rytilahti reviewed Dec 11, 2024
View reviewed changes
Comment thread tests/fixtures/iot/KL130(EU)_1.0_1.8.8.json Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread tests/fixtures/smart/P110M(AU)_1.0_1.2.3.json Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread tests/fixtures/iot/EP40(US)_1.0_1.0.2.json Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread kasa/protocols/smartprotocol.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread kasa/interfaces/light.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

@sdb9696
Update post review
4508c7c
@sdb9696
sdb9696 requested a review from rytilahti December 11, 2024 12:48
rytilahti
rytilahti approved these changes Dec 11, 2024
View reviewed changes

@rytilahti rytilahti left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge it, thanks a lot! :-)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@rytilahti
rytilahti merged commit 8cb5c2e into master Dec 11, 2024
@rytilahti
rytilahti deleted the janitor/dump_devinfo_raw branch December 11, 2024 13:18
@sdb9696 sdb9696 mentioned this pull request Dec 21, 2024
Prepare 0.9.0 #1401
Merged
sdb9696 added a commit that referenced this pull request Dec 21, 2024
@sdb9696
Prepare 0.9.0 (#1401)
63f4f82
## [0.9.0](https://github.com/python-kasa/python-kasa/tree/0.9.0) (2024-12-21)

[Full Changelog](0.8.1...0.9.0)

**Release highlights:**

- Improvements to Tapo camera support:
  - C100, C225, C325WB, C520WS and TC70 now supported.
  - Support for motion, person, tamper, and baby cry detection.
- Initial support for Tapo robovacs.
- API extended with `FeatureAttributes` for consumers to test for [supported features](https://python-kasa.readthedocs.io/en/stable/topics.html#modules-and-features).
- Experimental support for Kasa cameras[^1]

[^1]: Currently limited to devices not yet provisioned via the Tapo app - Many thanks to @Puxtril!

**Breaking changes:**

- Use DeviceInfo consistently across devices [\#1338](#1338) (@sdb9696)

**Implemented enhancements:**

- Add rssi and signal\_level to smartcam [\#1392](#1392) (@sdb9696)
- Add smartcam detection modules [\#1389](#1389) (@sdb9696)
- Add bare-bones matter modules to smart and smartcam devices [\#1371](#1371) (@sdb9696)
- Add bare bones homekit modules smart and smartcam devices [\#1370](#1370) (@sdb9696)
- Return raw discovery result in cli discover raw [\#1342](#1342) (@sdb9696)
- cli: print model, https, and lv for discover list [\#1339](#1339) (@rytilahti)
- Improve overheat reporting [\#1335](#1335) (@rytilahti)
- Provide alternative camera urls [\#1316](#1316) (@sdb9696)
- Add LinkieTransportV2 and basic IOT.IPCAMERA support [\#1270](#1270) (@Puxtril)
- Add ssltransport for robovacs [\#943](#943) (@rytilahti)

**Fixed bugs:**

- Tapo H200 Hub does not work with python-kasa [\#1149](#1149)
- Treat smartcam 500 errors after handshake as retryable [\#1395](#1395) (@sdb9696)
- Fix lens mask required component and state [\#1386](#1386) (@sdb9696)
- Add LensMask module to smartcam [\#1385](#1385) (@sdb9696)
- Do not error when accessing smart device\_type before update [\#1319](#1319) (@sdb9696)
- Fallback to other module data on get\_energy\_usage errors [\#1245](#1245) (@rytilahti)

**Added support for devices:**

- Add P210M\(US\) 1.0 1.0.3 fixture [\#1399](#1399) (@sdb9696)
- Add C225\(US\) 2.0 1.0.11 fixture [\#1398](#1398) (@sdb9696)
- Add P306\(US\) 1.0 1.1.2 fixture [\#1396](#1396) (@nakanaela)
- Add TC70 3.0 1.3.11 fixture [\#1390](#1390) (@sdb9696)
- Add C325WB\(EU\) 1.0 1.1.17 Fixture [\#1379](#1379) (@sdb9696)
- Add C100 4.0 1.3.14 Fixture [\#1378](#1378) (@sdb9696)
- Add KS200 \(US\) IOT Fixture and P115 \(US\) Smart Fixture [\#1355](#1355) (@ZeliardM)
- Add C520WS camera fixture [\#1352](#1352) (@Happy-Cadaver)

**Documentation updates:**

- Update docs for Tapo Lab Third-Party compatibility [\#1380](#1380) (@sdb9696)
- Add homebridge-kasa-python link to README [\#1367](#1367) (@rytilahti)
- Update docs for new FeatureAttribute behaviour [\#1365](#1365) (@sdb9696)
- Add link to related homeassistant-tapo-control [\#1333](#1333) (@rytilahti)

**Project maintenance:**

- Add P135 1.0 1.2.0 fixture [\#1397](#1397) (@sdb9696)
- Handle smartcam device blocked response [\#1393](#1393) (@sdb9696)
- Handle KeyboardInterrupts in the cli better [\#1391](#1391) (@sdb9696)
- Update C520WS fixture with new methods [\#1384](#1384) (@sdb9696)
- Miscellaneous minor fixes to dump\_devinfo [\#1382](#1382) (@sdb9696)
- Add timeout parameter to dump\_devinfo [\#1381](#1381) (@sdb9696)
- Simplify get\_protocol to prevent clashes with smartcam and robovac [\#1377](#1377) (@sdb9696)
- Add smartcam modules to package inits [\#1376](#1376) (@sdb9696)
- Enable saving of fixture files without git clone [\#1375](#1375) (@sdb9696)
- Force single for some smartcam requests [\#1374](#1374) (@sdb9696)
- Add new methods to dump\_devinfo [\#1373](#1373) (@sdb9696)
- Update cli, light modules, and docs to use FeatureAttributes [\#1364](#1364) (@sdb9696)
- Pass raw components to SmartChildDevice init [\#1363](#1363) (@sdb9696)
- Fix line endings in device\_fixtures.py [\#1361](#1361) (@sdb9696)
- Update dump\_devinfo for raw discovery json and common redactors [\#1358](#1358) (@sdb9696)
- Tweak RELEASING.md instructions for patch releases [\#1347](#1347) (@sdb9696)
- Scrub more vacuum keys [\#1328](#1328) (@rytilahti)
- Remove unnecessary check for python \<3.10 [\#1326](#1326) (@rytilahti)
- Add vacuum component queries to dump\_devinfo [\#1320](#1320) (@rytilahti)
- Handle missing mgt\_encryption\_schm in discovery [\#1318](#1318) (@sdb9696)
- Follow main package structure for tests [\#1317](#1317) (@rytilahti)
rytilahti pushed a commit to rytilahti/python-kasa that referenced this pull request Aug 31, 2025
@sdb9696 @rytilahti
Update dump_devinfo for raw discovery json and common redactors (pyth…
aa0b389
…on-kasa#1358)

This PR does a few related things to dump_devinfo:

- Store the raw discovery result in the fixture.
- Consolidate redaction logic so it's not duplicated in dump_devinfo.
- Update existing fixtures to:
  - Store raw discovery result under `result`
  - Use `SCRUBBED_CHILD_DEVICE_ID` everywhere
  - Have correct values as per the consolidated redactors.
rytilahti pushed a commit to rytilahti/python-kasa that referenced this pull request Aug 31, 2025
@sdb9696 @rytilahti
Prepare 0.9.0 (python-kasa#1401)
3d3cfd3
## [0.9.0](https://github.com/python-kasa/python-kasa/tree/0.9.0) (2024-12-21)

[Full Changelog](python-kasa/python-kasa@0.8.1...0.9.0)

**Release highlights:**

- Improvements to Tapo camera support:
  - C100, C225, C325WB, C520WS and TC70 now supported.
  - Support for motion, person, tamper, and baby cry detection.
- Initial support for Tapo robovacs.
- API extended with `FeatureAttributes` for consumers to test for [supported features](https://python-kasa.readthedocs.io/en/stable/topics.html#modules-and-features).
- Experimental support for Kasa cameras[^1]

[^1]: Currently limited to devices not yet provisioned via the Tapo app - Many thanks to @Puxtril!

**Breaking changes:**

- Use DeviceInfo consistently across devices [\python-kasa#1338](python-kasa#1338) (@sdb9696)

**Implemented enhancements:**

- Add rssi and signal\_level to smartcam [\python-kasa#1392](python-kasa#1392) (@sdb9696)
- Add smartcam detection modules [\python-kasa#1389](python-kasa#1389) (@sdb9696)
- Add bare-bones matter modules to smart and smartcam devices [\python-kasa#1371](python-kasa#1371) (@sdb9696)
- Add bare bones homekit modules smart and smartcam devices [\python-kasa#1370](python-kasa#1370) (@sdb9696)
- Return raw discovery result in cli discover raw [\python-kasa#1342](python-kasa#1342) (@sdb9696)
- cli: print model, https, and lv for discover list [\python-kasa#1339](python-kasa#1339) (@rytilahti)
- Improve overheat reporting [\python-kasa#1335](python-kasa#1335) (@rytilahti)
- Provide alternative camera urls [\python-kasa#1316](python-kasa#1316) (@sdb9696)
- Add LinkieTransportV2 and basic IOT.IPCAMERA support [\python-kasa#1270](python-kasa#1270) (@Puxtril)
- Add ssltransport for robovacs [\python-kasa#943](python-kasa#943) (@rytilahti)

**Fixed bugs:**

- Tapo H200 Hub does not work with python-kasa [\python-kasa#1149](python-kasa#1149)
- Treat smartcam 500 errors after handshake as retryable [\python-kasa#1395](python-kasa#1395) (@sdb9696)
- Fix lens mask required component and state [\python-kasa#1386](python-kasa#1386) (@sdb9696)
- Add LensMask module to smartcam [\python-kasa#1385](python-kasa#1385) (@sdb9696)
- Do not error when accessing smart device\_type before update [\python-kasa#1319](python-kasa#1319) (@sdb9696)
- Fallback to other module data on get\_energy\_usage errors [\python-kasa#1245](python-kasa#1245) (@rytilahti)

**Added support for devices:**

- Add P210M\(US\) 1.0 1.0.3 fixture [\python-kasa#1399](python-kasa#1399) (@sdb9696)
- Add C225\(US\) 2.0 1.0.11 fixture [\python-kasa#1398](python-kasa#1398) (@sdb9696)
- Add P306\(US\) 1.0 1.1.2 fixture [\python-kasa#1396](python-kasa#1396) (@nakanaela)
- Add TC70 3.0 1.3.11 fixture [\python-kasa#1390](python-kasa#1390) (@sdb9696)
- Add C325WB\(EU\) 1.0 1.1.17 Fixture [\python-kasa#1379](python-kasa#1379) (@sdb9696)
- Add C100 4.0 1.3.14 Fixture [\python-kasa#1378](python-kasa#1378) (@sdb9696)
- Add KS200 \(US\) IOT Fixture and P115 \(US\) Smart Fixture [\python-kasa#1355](python-kasa#1355) (@ZeliardM)
- Add C520WS camera fixture [\python-kasa#1352](python-kasa#1352) (@Happy-Cadaver)

**Documentation updates:**

- Update docs for Tapo Lab Third-Party compatibility [\python-kasa#1380](python-kasa#1380) (@sdb9696)
- Add homebridge-kasa-python link to README [\python-kasa#1367](python-kasa#1367) (@rytilahti)
- Update docs for new FeatureAttribute behaviour [\python-kasa#1365](python-kasa#1365) (@sdb9696)
- Add link to related homeassistant-tapo-control [\python-kasa#1333](python-kasa#1333) (@rytilahti)

**Project maintenance:**

- Add P135 1.0 1.2.0 fixture [\python-kasa#1397](python-kasa#1397) (@sdb9696)
- Handle smartcam device blocked response [\python-kasa#1393](python-kasa#1393) (@sdb9696)
- Handle KeyboardInterrupts in the cli better [\python-kasa#1391](python-kasa#1391) (@sdb9696)
- Update C520WS fixture with new methods [\python-kasa#1384](python-kasa#1384) (@sdb9696)
- Miscellaneous minor fixes to dump\_devinfo [\python-kasa#1382](python-kasa#1382) (@sdb9696)
- Add timeout parameter to dump\_devinfo [\python-kasa#1381](python-kasa#1381) (@sdb9696)
- Simplify get\_protocol to prevent clashes with smartcam and robovac [\python-kasa#1377](python-kasa#1377) (@sdb9696)
- Add smartcam modules to package inits [\python-kasa#1376](python-kasa#1376) (@sdb9696)
- Enable saving of fixture files without git clone [\python-kasa#1375](python-kasa#1375) (@sdb9696)
- Force single for some smartcam requests [\python-kasa#1374](python-kasa#1374) (@sdb9696)
- Add new methods to dump\_devinfo [\python-kasa#1373](python-kasa#1373) (@sdb9696)
- Update cli, light modules, and docs to use FeatureAttributes [\python-kasa#1364](python-kasa#1364) (@sdb9696)
- Pass raw components to SmartChildDevice init [\python-kasa#1363](python-kasa#1363) (@sdb9696)
- Fix line endings in device\_fixtures.py [\python-kasa#1361](python-kasa#1361) (@sdb9696)
- Update dump\_devinfo for raw discovery json and common redactors [\python-kasa#1358](python-kasa#1358) (@sdb9696)
- Tweak RELEASING.md instructions for patch releases [\python-kasa#1347](python-kasa#1347) (@sdb9696)
- Scrub more vacuum keys [\python-kasa#1328](python-kasa#1328) (@rytilahti)
- Remove unnecessary check for python \<3.10 [\python-kasa#1326](python-kasa#1326) (@rytilahti)
- Add vacuum component queries to dump\_devinfo [\python-kasa#1320](python-kasa#1320) (@rytilahti)
- Handle missing mgt\_encryption\_schm in discovery [\python-kasa#1318](python-kasa#1318) (@sdb9696)
- Follow main package structure for tests [\python-kasa#1317](python-kasa#1317) (@rytilahti)
rytilahti pushed a commit to rytilahti/python-kasa that referenced this pull request Oct 26, 2025
@sdb9696 @rytilahti
Update dump_devinfo for raw discovery json and common redactors (pyth…
9c30464
…on-kasa#1358)

This PR does a few related things to dump_devinfo:

- Store the raw discovery result in the fixture.
- Consolidate redaction logic so it's not duplicated in dump_devinfo.
- Update existing fixtures to:
  - Store raw discovery result under `result`
  - Use `SCRUBBED_CHILD_DEVICE_ID` everywhere
  - Have correct values as per the consolidated redactors.
rytilahti pushed a commit to rytilahti/python-kasa that referenced this pull request Oct 26, 2025
@sdb9696 @rytilahti
Prepare 0.9.0 (python-kasa#1401)
8831307
## [0.9.0](https://github.com/python-kasa/python-kasa/tree/0.9.0) (2024-12-21)

[Full Changelog](python-kasa/python-kasa@0.8.1...0.9.0)

**Release highlights:**

- Improvements to Tapo camera support:
  - C100, C225, C325WB, C520WS and TC70 now supported.
  - Support for motion, person, tamper, and baby cry detection.
- Initial support for Tapo robovacs.
- API extended with `FeatureAttributes` for consumers to test for [supported features](https://python-kasa.readthedocs.io/en/stable/topics.html#modules-and-features).
- Experimental support for Kasa cameras[^1]

[^1]: Currently limited to devices not yet provisioned via the Tapo app - Many thanks to @Puxtril!

**Breaking changes:**

- Use DeviceInfo consistently across devices [\python-kasa#1338](python-kasa#1338) (@sdb9696)

**Implemented enhancements:**

- Add rssi and signal\_level to smartcam [\python-kasa#1392](python-kasa#1392) (@sdb9696)
- Add smartcam detection modules [\python-kasa#1389](python-kasa#1389) (@sdb9696)
- Add bare-bones matter modules to smart and smartcam devices [\python-kasa#1371](python-kasa#1371) (@sdb9696)
- Add bare bones homekit modules smart and smartcam devices [\python-kasa#1370](python-kasa#1370) (@sdb9696)
- Return raw discovery result in cli discover raw [\python-kasa#1342](python-kasa#1342) (@sdb9696)
- cli: print model, https, and lv for discover list [\python-kasa#1339](python-kasa#1339) (@rytilahti)
- Improve overheat reporting [\python-kasa#1335](python-kasa#1335) (@rytilahti)
- Provide alternative camera urls [\python-kasa#1316](python-kasa#1316) (@sdb9696)
- Add LinkieTransportV2 and basic IOT.IPCAMERA support [\python-kasa#1270](python-kasa#1270) (@Puxtril)
- Add ssltransport for robovacs [\python-kasa#943](python-kasa#943) (@rytilahti)

**Fixed bugs:**

- Tapo H200 Hub does not work with python-kasa [\python-kasa#1149](python-kasa#1149)
- Treat smartcam 500 errors after handshake as retryable [\python-kasa#1395](python-kasa#1395) (@sdb9696)
- Fix lens mask required component and state [\python-kasa#1386](python-kasa#1386) (@sdb9696)
- Add LensMask module to smartcam [\python-kasa#1385](python-kasa#1385) (@sdb9696)
- Do not error when accessing smart device\_type before update [\python-kasa#1319](python-kasa#1319) (@sdb9696)
- Fallback to other module data on get\_energy\_usage errors [\python-kasa#1245](python-kasa#1245) (@rytilahti)

**Added support for devices:**

- Add P210M\(US\) 1.0 1.0.3 fixture [\python-kasa#1399](python-kasa#1399) (@sdb9696)
- Add C225\(US\) 2.0 1.0.11 fixture [\python-kasa#1398](python-kasa#1398) (@sdb9696)
- Add P306\(US\) 1.0 1.1.2 fixture [\python-kasa#1396](python-kasa#1396) (@nakanaela)
- Add TC70 3.0 1.3.11 fixture [\python-kasa#1390](python-kasa#1390) (@sdb9696)
- Add C325WB\(EU\) 1.0 1.1.17 Fixture [\python-kasa#1379](python-kasa#1379) (@sdb9696)
- Add C100 4.0 1.3.14 Fixture [\python-kasa#1378](python-kasa#1378) (@sdb9696)
- Add KS200 \(US\) IOT Fixture and P115 \(US\) Smart Fixture [\python-kasa#1355](python-kasa#1355) (@ZeliardM)
- Add C520WS camera fixture [\python-kasa#1352](python-kasa#1352) (@Happy-Cadaver)

**Documentation updates:**

- Update docs for Tapo Lab Third-Party compatibility [\python-kasa#1380](python-kasa#1380) (@sdb9696)
- Add homebridge-kasa-python link to README [\python-kasa#1367](python-kasa#1367) (@rytilahti)
- Update docs for new FeatureAttribute behaviour [\python-kasa#1365](python-kasa#1365) (@sdb9696)
- Add link to related homeassistant-tapo-control [\python-kasa#1333](python-kasa#1333) (@rytilahti)

**Project maintenance:**

- Add P135 1.0 1.2.0 fixture [\python-kasa#1397](python-kasa#1397) (@sdb9696)
- Handle smartcam device blocked response [\python-kasa#1393](python-kasa#1393) (@sdb9696)
- Handle KeyboardInterrupts in the cli better [\python-kasa#1391](python-kasa#1391) (@sdb9696)
- Update C520WS fixture with new methods [\python-kasa#1384](python-kasa#1384) (@sdb9696)
- Miscellaneous minor fixes to dump\_devinfo [\python-kasa#1382](python-kasa#1382) (@sdb9696)
- Add timeout parameter to dump\_devinfo [\python-kasa#1381](python-kasa#1381) (@sdb9696)
- Simplify get\_protocol to prevent clashes with smartcam and robovac [\python-kasa#1377](python-kasa#1377) (@sdb9696)
- Add smartcam modules to package inits [\python-kasa#1376](python-kasa#1376) (@sdb9696)
- Enable saving of fixture files without git clone [\python-kasa#1375](python-kasa#1375) (@sdb9696)
- Force single for some smartcam requests [\python-kasa#1374](python-kasa#1374) (@sdb9696)
- Add new methods to dump\_devinfo [\python-kasa#1373](python-kasa#1373) (@sdb9696)
- Update cli, light modules, and docs to use FeatureAttributes [\python-kasa#1364](python-kasa#1364) (@sdb9696)
- Pass raw components to SmartChildDevice init [\python-kasa#1363](python-kasa#1363) (@sdb9696)
- Fix line endings in device\_fixtures.py [\python-kasa#1361](python-kasa#1361) (@sdb9696)
- Update dump\_devinfo for raw discovery json and common redactors [\python-kasa#1358](python-kasa#1358) (@sdb9696)
- Tweak RELEASING.md instructions for patch releases [\python-kasa#1347](python-kasa#1347) (@sdb9696)
- Scrub more vacuum keys [\python-kasa#1328](python-kasa#1328) (@rytilahti)
- Remove unnecessary check for python \<3.10 [\python-kasa#1326](python-kasa#1326) (@rytilahti)
- Add vacuum component queries to dump\_devinfo [\python-kasa#1320](python-kasa#1320) (@rytilahti)
- Handle missing mgt\_encryption\_schm in discovery [\python-kasa#1318](python-kasa#1318) (@sdb9696)
- Follow main package structure for tests [\python-kasa#1317](python-kasa#1317) (@rytilahti)
rytilahti pushed a commit to rytilahti/python-kasa that referenced this pull request Nov 10, 2025
@sdb9696 @rytilahti
Update dump_devinfo for raw discovery json and common redactors (pyth…
852ee8b
…on-kasa#1358)

This PR does a few related things to dump_devinfo:

- Store the raw discovery result in the fixture.
- Consolidate redaction logic so it's not duplicated in dump_devinfo.
- Update existing fixtures to:
  - Store raw discovery result under `result`
  - Use `SCRUBBED_CHILD_DEVICE_ID` everywhere
  - Have correct values as per the consolidated redactors.
rytilahti pushed a commit to rytilahti/python-kasa that referenced this pull request Nov 10, 2025
@sdb9696 @rytilahti
Prepare 0.9.0 (python-kasa#1401)
3ce868a
## [0.9.0](https://github.com/python-kasa/python-kasa/tree/0.9.0) (2024-12-21)

[Full Changelog](python-kasa/python-kasa@0.8.1...0.9.0)

**Release highlights:**

- Improvements to Tapo camera support:
  - C100, C225, C325WB, C520WS and TC70 now supported.
  - Support for motion, person, tamper, and baby cry detection.
- Initial support for Tapo robovacs.
- API extended with `FeatureAttributes` for consumers to test for [supported features](https://python-kasa.readthedocs.io/en/stable/topics.html#modules-and-features).
- Experimental support for Kasa cameras[^1]

[^1]: Currently limited to devices not yet provisioned via the Tapo app - Many thanks to @Puxtril!

**Breaking changes:**

- Use DeviceInfo consistently across devices [\python-kasa#1338](python-kasa#1338) (@sdb9696)

**Implemented enhancements:**

- Add rssi and signal\_level to smartcam [\python-kasa#1392](python-kasa#1392) (@sdb9696)
- Add smartcam detection modules [\python-kasa#1389](python-kasa#1389) (@sdb9696)
- Add bare-bones matter modules to smart and smartcam devices [\python-kasa#1371](python-kasa#1371) (@sdb9696)
- Add bare bones homekit modules smart and smartcam devices [\python-kasa#1370](python-kasa#1370) (@sdb9696)
- Return raw discovery result in cli discover raw [\python-kasa#1342](python-kasa#1342) (@sdb9696)
- cli: print model, https, and lv for discover list [\python-kasa#1339](python-kasa#1339) (@rytilahti)
- Improve overheat reporting [\python-kasa#1335](python-kasa#1335) (@rytilahti)
- Provide alternative camera urls [\python-kasa#1316](python-kasa#1316) (@sdb9696)
- Add LinkieTransportV2 and basic IOT.IPCAMERA support [\python-kasa#1270](python-kasa#1270) (@Puxtril)
- Add ssltransport for robovacs [\python-kasa#943](python-kasa#943) (@rytilahti)

**Fixed bugs:**

- Tapo H200 Hub does not work with python-kasa [\python-kasa#1149](python-kasa#1149)
- Treat smartcam 500 errors after handshake as retryable [\python-kasa#1395](python-kasa#1395) (@sdb9696)
- Fix lens mask required component and state [\python-kasa#1386](python-kasa#1386) (@sdb9696)
- Add LensMask module to smartcam [\python-kasa#1385](python-kasa#1385) (@sdb9696)
- Do not error when accessing smart device\_type before update [\python-kasa#1319](python-kasa#1319) (@sdb9696)
- Fallback to other module data on get\_energy\_usage errors [\python-kasa#1245](python-kasa#1245) (@rytilahti)

**Added support for devices:**

- Add P210M\(US\) 1.0 1.0.3 fixture [\python-kasa#1399](python-kasa#1399) (@sdb9696)
- Add C225\(US\) 2.0 1.0.11 fixture [\python-kasa#1398](python-kasa#1398) (@sdb9696)
- Add P306\(US\) 1.0 1.1.2 fixture [\python-kasa#1396](python-kasa#1396) (@nakanaela)
- Add TC70 3.0 1.3.11 fixture [\python-kasa#1390](python-kasa#1390) (@sdb9696)
- Add C325WB\(EU\) 1.0 1.1.17 Fixture [\python-kasa#1379](python-kasa#1379) (@sdb9696)
- Add C100 4.0 1.3.14 Fixture [\python-kasa#1378](python-kasa#1378) (@sdb9696)
- Add KS200 \(US\) IOT Fixture and P115 \(US\) Smart Fixture [\python-kasa#1355](python-kasa#1355) (@ZeliardM)
- Add C520WS camera fixture [\python-kasa#1352](python-kasa#1352) (@Happy-Cadaver)

**Documentation updates:**

- Update docs for Tapo Lab Third-Party compatibility [\python-kasa#1380](python-kasa#1380) (@sdb9696)
- Add homebridge-kasa-python link to README [\python-kasa#1367](python-kasa#1367) (@rytilahti)
- Update docs for new FeatureAttribute behaviour [\python-kasa#1365](python-kasa#1365) (@sdb9696)
- Add link to related homeassistant-tapo-control [\python-kasa#1333](python-kasa#1333) (@rytilahti)

**Project maintenance:**

- Add P135 1.0 1.2.0 fixture [\python-kasa#1397](python-kasa#1397) (@sdb9696)
- Handle smartcam device blocked response [\python-kasa#1393](python-kasa#1393) (@sdb9696)
- Handle KeyboardInterrupts in the cli better [\python-kasa#1391](python-kasa#1391) (@sdb9696)
- Update C520WS fixture with new methods [\python-kasa#1384](python-kasa#1384) (@sdb9696)
- Miscellaneous minor fixes to dump\_devinfo [\python-kasa#1382](python-kasa#1382) (@sdb9696)
- Add timeout parameter to dump\_devinfo [\python-kasa#1381](python-kasa#1381) (@sdb9696)
- Simplify get\_protocol to prevent clashes with smartcam and robovac [\python-kasa#1377](python-kasa#1377) (@sdb9696)
- Add smartcam modules to package inits [\python-kasa#1376](python-kasa#1376) (@sdb9696)
- Enable saving of fixture files without git clone [\python-kasa#1375](python-kasa#1375) (@sdb9696)
- Force single for some smartcam requests [\python-kasa#1374](python-kasa#1374) (@sdb9696)
- Add new methods to dump\_devinfo [\python-kasa#1373](python-kasa#1373) (@sdb9696)
- Update cli, light modules, and docs to use FeatureAttributes [\python-kasa#1364](python-kasa#1364) (@sdb9696)
- Pass raw components to SmartChildDevice init [\python-kasa#1363](python-kasa#1363) (@sdb9696)
- Fix line endings in device\_fixtures.py [\python-kasa#1361](python-kasa#1361) (@sdb9696)
- Update dump\_devinfo for raw discovery json and common redactors [\python-kasa#1358](python-kasa#1358) (@sdb9696)
- Tweak RELEASING.md instructions for patch releases [\python-kasa#1347](python-kasa#1347) (@sdb9696)
- Scrub more vacuum keys [\python-kasa#1328](python-kasa#1328) (@rytilahti)
- Remove unnecessary check for python \<3.10 [\python-kasa#1326](python-kasa#1326) (@rytilahti)
- Add vacuum component queries to dump\_devinfo [\python-kasa#1320](python-kasa#1320) (@rytilahti)
- Handle missing mgt\_encryption\_schm in discovery [\python-kasa#1318](python-kasa#1318) (@sdb9696)
- Follow main package structure for tests [\python-kasa#1317](python-kasa#1317) (@rytilahti)
rytilahti pushed a commit to rytilahti/python-kasa that referenced this pull request Jul 5, 2026
@sdb9696 @rytilahti
Update dump_devinfo for raw discovery json and common redactors (pyth…
9d720c3
…on-kasa#1358)

This PR does a few related things to dump_devinfo:

- Store the raw discovery result in the fixture.
- Consolidate redaction logic so it's not duplicated in dump_devinfo.
- Update existing fixtures to:
  - Store raw discovery result under `result`
  - Use `SCRUBBED_CHILD_DEVICE_ID` everywhere
  - Have correct values as per the consolidated redactors.
rytilahti pushed a commit to rytilahti/python-kasa that referenced this pull request Jul 5, 2026
@sdb9696 @rytilahti
Prepare 0.9.0 (python-kasa#1401)
eab1fdf
## [0.9.0](https://github.com/python-kasa/python-kasa/tree/0.9.0) (2024-12-21)

[Full Changelog](python-kasa/python-kasa@0.8.1...0.9.0)

**Release highlights:**

- Improvements to Tapo camera support:
  - C100, C225, C325WB, C520WS and TC70 now supported.
  - Support for motion, person, tamper, and baby cry detection.
- Initial support for Tapo robovacs.
- API extended with `FeatureAttributes` for consumers to test for [supported features](https://python-kasa.readthedocs.io/en/stable/topics.html#modules-and-features).
- Experimental support for Kasa cameras[^1]

[^1]: Currently limited to devices not yet provisioned via the Tapo app - Many thanks to @Puxtril!

**Breaking changes:**

- Use DeviceInfo consistently across devices [\python-kasa#1338](python-kasa#1338) (@sdb9696)

**Implemented enhancements:**

- Add rssi and signal\_level to smartcam [\python-kasa#1392](python-kasa#1392) (@sdb9696)
- Add smartcam detection modules [\python-kasa#1389](python-kasa#1389) (@sdb9696)
- Add bare-bones matter modules to smart and smartcam devices [\python-kasa#1371](python-kasa#1371) (@sdb9696)
- Add bare bones homekit modules smart and smartcam devices [\python-kasa#1370](python-kasa#1370) (@sdb9696)
- Return raw discovery result in cli discover raw [\python-kasa#1342](python-kasa#1342) (@sdb9696)
- cli: print model, https, and lv for discover list [\python-kasa#1339](python-kasa#1339) (@rytilahti)
- Improve overheat reporting [\python-kasa#1335](python-kasa#1335) (@rytilahti)
- Provide alternative camera urls [\python-kasa#1316](python-kasa#1316) (@sdb9696)
- Add LinkieTransportV2 and basic IOT.IPCAMERA support [\python-kasa#1270](python-kasa#1270) (@Puxtril)
- Add ssltransport for robovacs [\python-kasa#943](python-kasa#943) (@rytilahti)

**Fixed bugs:**

- Tapo H200 Hub does not work with python-kasa [\python-kasa#1149](python-kasa#1149)
- Treat smartcam 500 errors after handshake as retryable [\python-kasa#1395](python-kasa#1395) (@sdb9696)
- Fix lens mask required component and state [\python-kasa#1386](python-kasa#1386) (@sdb9696)
- Add LensMask module to smartcam [\python-kasa#1385](python-kasa#1385) (@sdb9696)
- Do not error when accessing smart device\_type before update [\python-kasa#1319](python-kasa#1319) (@sdb9696)
- Fallback to other module data on get\_energy\_usage errors [\python-kasa#1245](python-kasa#1245) (@rytilahti)

**Added support for devices:**

- Add P210M\(US\) 1.0 1.0.3 fixture [\python-kasa#1399](python-kasa#1399) (@sdb9696)
- Add C225\(US\) 2.0 1.0.11 fixture [\python-kasa#1398](python-kasa#1398) (@sdb9696)
- Add P306\(US\) 1.0 1.1.2 fixture [\python-kasa#1396](python-kasa#1396) (@nakanaela)
- Add TC70 3.0 1.3.11 fixture [\python-kasa#1390](python-kasa#1390) (@sdb9696)
- Add C325WB\(EU\) 1.0 1.1.17 Fixture [\python-kasa#1379](python-kasa#1379) (@sdb9696)
- Add C100 4.0 1.3.14 Fixture [\python-kasa#1378](python-kasa#1378) (@sdb9696)
- Add KS200 \(US\) IOT Fixture and P115 \(US\) Smart Fixture [\python-kasa#1355](python-kasa#1355) (@ZeliardM)
- Add C520WS camera fixture [\python-kasa#1352](python-kasa#1352) (@Happy-Cadaver)

**Documentation updates:**

- Update docs for Tapo Lab Third-Party compatibility [\python-kasa#1380](python-kasa#1380) (@sdb9696)
- Add homebridge-kasa-python link to README [\python-kasa#1367](python-kasa#1367) (@rytilahti)
- Update docs for new FeatureAttribute behaviour [\python-kasa#1365](python-kasa#1365) (@sdb9696)
- Add link to related homeassistant-tapo-control [\python-kasa#1333](python-kasa#1333) (@rytilahti)

**Project maintenance:**

- Add P135 1.0 1.2.0 fixture [\python-kasa#1397](python-kasa#1397) (@sdb9696)
- Handle smartcam device blocked response [\python-kasa#1393](python-kasa#1393) (@sdb9696)
- Handle KeyboardInterrupts in the cli better [\python-kasa#1391](python-kasa#1391) (@sdb9696)
- Update C520WS fixture with new methods [\python-kasa#1384](python-kasa#1384) (@sdb9696)
- Miscellaneous minor fixes to dump\_devinfo [\python-kasa#1382](python-kasa#1382) (@sdb9696)
- Add timeout parameter to dump\_devinfo [\python-kasa#1381](python-kasa#1381) (@sdb9696)
- Simplify get\_protocol to prevent clashes with smartcam and robovac [\python-kasa#1377](python-kasa#1377) (@sdb9696)
- Add smartcam modules to package inits [\python-kasa#1376](python-kasa#1376) (@sdb9696)
- Enable saving of fixture files without git clone [\python-kasa#1375](python-kasa#1375) (@sdb9696)
- Force single for some smartcam requests [\python-kasa#1374](python-kasa#1374) (@sdb9696)
- Add new methods to dump\_devinfo [\python-kasa#1373](python-kasa#1373) (@sdb9696)
- Update cli, light modules, and docs to use FeatureAttributes [\python-kasa#1364](python-kasa#1364) (@sdb9696)
- Pass raw components to SmartChildDevice init [\python-kasa#1363](python-kasa#1363) (@sdb9696)
- Fix line endings in device\_fixtures.py [\python-kasa#1361](python-kasa#1361) (@sdb9696)
- Update dump\_devinfo for raw discovery json and common redactors [\python-kasa#1358](python-kasa#1358) (@sdb9696)
- Tweak RELEASING.md instructions for patch releases [\python-kasa#1347](python-kasa#1347) (@sdb9696)
- Scrub more vacuum keys [\python-kasa#1328](python-kasa#1328) (@rytilahti)
- Remove unnecessary check for python \<3.10 [\python-kasa#1326](python-kasa#1326) (@rytilahti)
- Add vacuum component queries to dump\_devinfo [\python-kasa#1320](python-kasa#1320) (@rytilahti)
- Handle missing mgt\_encryption\_schm in discovery [\python-kasa#1318](python-kasa#1318) (@sdb9696)
- Follow main package structure for tests [\python-kasa#1317](python-kasa#1317) (@rytilahti)
pillarsdotnet pushed a commit to pillarsdotnet/python-kasa that referenced this pull request Oct 22, 2026
@sdb9696
Update dump_devinfo for raw discovery json and common redactors (pyth…
394b43c
…on-kasa#1358)

This PR does a few related things to dump_devinfo:

- Store the raw discovery result in the fixture.
- Consolidate redaction logic so it's not duplicated in dump_devinfo.
- Update existing fixtures to:
  - Store raw discovery result under `result`
  - Use `SCRUBBED_CHILD_DEVICE_ID` everywhere
  - Have correct values as per the consolidated redactors.
pillarsdotnet pushed a commit to pillarsdotnet/python-kasa that referenced this pull request Oct 22, 2026
@sdb9696
Prepare 0.9.0 (python-kasa#1401)
2dcad8b
## [0.9.0](https://github.com/python-kasa/python-kasa/tree/0.9.0) (2024-12-21)

[Full Changelog](python-kasa/python-kasa@0.8.1...0.9.0)

**Release highlights:**

- Improvements to Tapo camera support:
  - C100, C225, C325WB, C520WS and TC70 now supported.
  - Support for motion, person, tamper, and baby cry detection.
- Initial support for Tapo robovacs.
- API extended with `FeatureAttributes` for consumers to test for [supported features](https://python-kasa.readthedocs.io/en/stable/topics.html#modules-and-features).
- Experimental support for Kasa cameras[^1]

[^1]: Currently limited to devices not yet provisioned via the Tapo app - Many thanks to @Puxtril!

**Breaking changes:**

- Use DeviceInfo consistently across devices [\python-kasa#1338](python-kasa#1338) (@sdb9696)

**Implemented enhancements:**

- Add rssi and signal\_level to smartcam [\python-kasa#1392](python-kasa#1392) (@sdb9696)
- Add smartcam detection modules [\python-kasa#1389](python-kasa#1389) (@sdb9696)
- Add bare-bones matter modules to smart and smartcam devices [\python-kasa#1371](python-kasa#1371) (@sdb9696)
- Add bare bones homekit modules smart and smartcam devices [\python-kasa#1370](python-kasa#1370) (@sdb9696)
- Return raw discovery result in cli discover raw [\python-kasa#1342](python-kasa#1342) (@sdb9696)
- cli: print model, https, and lv for discover list [\python-kasa#1339](python-kasa#1339) (@rytilahti)
- Improve overheat reporting [\python-kasa#1335](python-kasa#1335) (@rytilahti)
- Provide alternative camera urls [\python-kasa#1316](python-kasa#1316) (@sdb9696)
- Add LinkieTransportV2 and basic IOT.IPCAMERA support [\python-kasa#1270](python-kasa#1270) (@Puxtril)
- Add ssltransport for robovacs [\python-kasa#943](python-kasa#943) (@rytilahti)

**Fixed bugs:**

- Tapo H200 Hub does not work with python-kasa [\python-kasa#1149](python-kasa#1149)
- Treat smartcam 500 errors after handshake as retryable [\python-kasa#1395](python-kasa#1395) (@sdb9696)
- Fix lens mask required component and state [\python-kasa#1386](python-kasa#1386) (@sdb9696)
- Add LensMask module to smartcam [\python-kasa#1385](python-kasa#1385) (@sdb9696)
- Do not error when accessing smart device\_type before update [\python-kasa#1319](python-kasa#1319) (@sdb9696)
- Fallback to other module data on get\_energy\_usage errors [\python-kasa#1245](python-kasa#1245) (@rytilahti)

**Added support for devices:**

- Add P210M\(US\) 1.0 1.0.3 fixture [\python-kasa#1399](python-kasa#1399) (@sdb9696)
- Add C225\(US\) 2.0 1.0.11 fixture [\python-kasa#1398](python-kasa#1398) (@sdb9696)
- Add P306\(US\) 1.0 1.1.2 fixture [\python-kasa#1396](python-kasa#1396) (@nakanaela)
- Add TC70 3.0 1.3.11 fixture [\python-kasa#1390](python-kasa#1390) (@sdb9696)
- Add C325WB\(EU\) 1.0 1.1.17 Fixture [\python-kasa#1379](python-kasa#1379) (@sdb9696)
- Add C100 4.0 1.3.14 Fixture [\python-kasa#1378](python-kasa#1378) (@sdb9696)
- Add KS200 \(US\) IOT Fixture and P115 \(US\) Smart Fixture [\python-kasa#1355](python-kasa#1355) (@ZeliardM)
- Add C520WS camera fixture [\python-kasa#1352](python-kasa#1352) (@Happy-Cadaver)

**Documentation updates:**

- Update docs for Tapo Lab Third-Party compatibility [\python-kasa#1380](python-kasa#1380) (@sdb9696)
- Add homebridge-kasa-python link to README [\python-kasa#1367](python-kasa#1367) (@rytilahti)
- Update docs for new FeatureAttribute behaviour [\python-kasa#1365](python-kasa#1365) (@sdb9696)
- Add link to related homeassistant-tapo-control [\python-kasa#1333](python-kasa#1333) (@rytilahti)

**Project maintenance:**

- Add P135 1.0 1.2.0 fixture [\python-kasa#1397](python-kasa#1397) (@sdb9696)
- Handle smartcam device blocked response [\python-kasa#1393](python-kasa#1393) (@sdb9696)
- Handle KeyboardInterrupts in the cli better [\python-kasa#1391](python-kasa#1391) (@sdb9696)
- Update C520WS fixture with new methods [\python-kasa#1384](python-kasa#1384) (@sdb9696)
- Miscellaneous minor fixes to dump\_devinfo [\python-kasa#1382](python-kasa#1382) (@sdb9696)
- Add timeout parameter to dump\_devinfo [\python-kasa#1381](python-kasa#1381) (@sdb9696)
- Simplify get\_protocol to prevent clashes with smartcam and robovac [\python-kasa#1377](python-kasa#1377) (@sdb9696)
- Add smartcam modules to package inits [\python-kasa#1376](python-kasa#1376) (@sdb9696)
- Enable saving of fixture files without git clone [\python-kasa#1375](python-kasa#1375) (@sdb9696)
- Force single for some smartcam requests [\python-kasa#1374](python-kasa#1374) (@sdb9696)
- Add new methods to dump\_devinfo [\python-kasa#1373](python-kasa#1373) (@sdb9696)
- Update cli, light modules, and docs to use FeatureAttributes [\python-kasa#1364](python-kasa#1364) (@sdb9696)
- Pass raw components to SmartChildDevice init [\python-kasa#1363](python-kasa#1363) (@sdb9696)
- Fix line endings in device\_fixtures.py [\python-kasa#1361](python-kasa#1361) (@sdb9696)
- Update dump\_devinfo for raw discovery json and common redactors [\python-kasa#1358](python-kasa#1358) (@sdb9696)
- Tweak RELEASING.md instructions for patch releases [\python-kasa#1347](python-kasa#1347) (@sdb9696)
- Scrub more vacuum keys [\python-kasa#1328](python-kasa#1328) (@rytilahti)
- Remove unnecessary check for python \<3.10 [\python-kasa#1326](python-kasa#1326) (@rytilahti)
- Add vacuum component queries to dump\_devinfo [\python-kasa#1320](python-kasa#1320) (@rytilahti)
- Handle missing mgt\_encryption\_schm in discovery [\python-kasa#1318](python-kasa#1318) (@sdb9696)
- Follow main package structure for tests [\python-kasa#1317](python-kasa#1317) (@rytilahti)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rytilahti rytilahti rytilahti approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

maintenance Project improvements and maintenance

Projects

None yet

Milestone

0.9.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@sdb9696 @rytilahti
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.