GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Add FeatureAttributes to smartcam Alarm by sdb9696 · Pull Request #1489 · python-kasa/python-kasa

Conversation

sdb9696 commented Jan 27, 2025 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

These were missed off in #1479. Testing with HA PR 136642 picked this up.

Adding a test case for this highlighted that the decorators currently lose the Annotated annotations which functools.wraps fixes.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Add FeatureAttributes to smartcam Alarm

a8fde52

sdb9696 added the bug Something isn't working label

Jan 27, 2025

sdb9696 added this to the 0.10.1 milestone

Jan 27, 2025

codecov Bot commented Jan 27, 2025 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.64%. Comparing base (ebd370d) to head (5b25084).
Report is 13 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1489      +/-   ##
==========================================
+ Coverage   92.63%   92.64%   +0.01%     
==========================================
  Files         149      149              
  Lines        9434     9439       +5     
  Branches      958      958              
==========================================
+ Hits         8739     8745       +6     
+ Misses        498      496       -2     
- Partials      197      198       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

sdb9696 requested a review from rytilahti

January 29, 2025 16:23

sdb9696 commented

Jan 29, 2025

View reviewed changes

Comment thread

kasa/interfaces/energy.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

sdb9696 commented

Jan 29, 2025

View reviewed changes

Comment thread

kasa/smart/smartmodule.py

		"""

		async def _async_wrap(self: _T, args: _P.args, *kwargs: _P.kwargs) -> dict:
		@wraps(func)

sdb9696 Jan 29, 2025

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was previously not working when using a decorator which the test cases highlighted. i.e. if using a decorator the type hints were not copied to the decorator function so get_feature would fail.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

rytilahti reacted with thumbs up emoji

All reactions

👍 1 reaction

rytilahti approved these changes

Jan 29, 2025

View reviewed changes

rytilahti left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of readability nits, feel free to fix/merge as you wish.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

tests/test_common_modules.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

tests/test_common_modules.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

tests/test_common_modules.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

tests/test_common_modules.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

sdb9696 and others added 3 commits

January 29, 2025 19:26


          Address code review suggestions

cc7bd03


          Update tests/test_common_modules.py

fb2c12c

Co-authored-by: Teemu R. <[email protected]>


          Merge branch 'master' into fix/smartcam_alarm

5b25084

sdb9696 enabled auto-merge (squash)

January 29, 2025 19:29

sdb9696 merged commit 44c561b into master

Jan 29, 2025

sdb9696 deleted the fix/smartcam_alarm branch

January 29, 2025 19:32

sdb9696 mentioned this pull request

Jan 31, 2025

Prepare 0.10.1 #1494

Merged

sdb9696 added a commit that referenced this pull request

Feb 2, 2025


          Prepare 0.10.1 (#1494)

cbab40a

## [0.10.1](https://github.com/python-kasa/python-kasa/tree/0.10.1) (2025-02-02)

[Full Changelog](0.10.0...0.10.1)

**Release summary:**

Small patch release for bugfixes

**Implemented enhancements:**

- dustbin\_mode: add 'off' mode for cleaner downstream impl [\#1488](#1488) (@rytilahti)
- Add Dimmer Configuration Support [\#1484](#1484) (@ryenitcher)

**Fixed bugs:**

- Do not return empty string for custom light effect name [\#1491](#1491) (@sdb9696)
- Add FeatureAttributes to smartcam Alarm [\#1489](#1489) (@sdb9696)

**Project maintenance:**

- Add module.device to the public api [\#1478](#1478) (@sdb9696)

rytilahti added a commit to rytilahti/python-kasa that referenced this pull request

Aug 31, 2025


          Add FeatureAttributes to smartcam Alarm (python-kasa#1489)

56c7fac

Co-authored-by: Teemu R. <[email protected]>

rytilahti pushed a commit to rytilahti/python-kasa that referenced this pull request

Aug 31, 2025


          Prepare 0.10.1 (python-kasa#1494)

1c6ceb5

## [0.10.1](https://github.com/python-kasa/python-kasa/tree/0.10.1) (2025-02-02)

[Full Changelog](python-kasa/python-kasa@0.10.0...0.10.1)

**Release summary:**

Small patch release for bugfixes

**Implemented enhancements:**

- dustbin\_mode: add 'off' mode for cleaner downstream impl [\python-kasa#1488](python-kasa#1488) (@rytilahti)
- Add Dimmer Configuration Support [\python-kasa#1484](python-kasa#1484) (@ryenitcher)

**Fixed bugs:**

- Do not return empty string for custom light effect name [\python-kasa#1491](python-kasa#1491) (@sdb9696)
- Add FeatureAttributes to smartcam Alarm [\python-kasa#1489](python-kasa#1489) (@sdb9696)

**Project maintenance:**

- Add module.device to the public api [\python-kasa#1478](python-kasa#1478) (@sdb9696)

rytilahti added a commit to rytilahti/python-kasa that referenced this pull request

Oct 26, 2025


          Add FeatureAttributes to smartcam Alarm (python-kasa#1489)

50a39ef

Co-authored-by: Teemu R. <[email protected]>

rytilahti pushed a commit to rytilahti/python-kasa that referenced this pull request

Oct 26, 2025


          Prepare 0.10.1 (python-kasa#1494)

9b22056

## [0.10.1](https://github.com/python-kasa/python-kasa/tree/0.10.1) (2025-02-02)

[Full Changelog](python-kasa/python-kasa@0.10.0...0.10.1)

**Release summary:**

Small patch release for bugfixes

**Implemented enhancements:**

- dustbin\_mode: add 'off' mode for cleaner downstream impl [\python-kasa#1488](python-kasa#1488) (@rytilahti)
- Add Dimmer Configuration Support [\python-kasa#1484](python-kasa#1484) (@ryenitcher)

**Fixed bugs:**

- Do not return empty string for custom light effect name [\python-kasa#1491](python-kasa#1491) (@sdb9696)
- Add FeatureAttributes to smartcam Alarm [\python-kasa#1489](python-kasa#1489) (@sdb9696)

**Project maintenance:**

- Add module.device to the public api [\python-kasa#1478](python-kasa#1478) (@sdb9696)

rytilahti added a commit to rytilahti/python-kasa that referenced this pull request

Nov 10, 2025


          Add FeatureAttributes to smartcam Alarm (python-kasa#1489)

b2565b4

Co-authored-by: Teemu R. <[email protected]>

rytilahti pushed a commit to rytilahti/python-kasa that referenced this pull request

Nov 10, 2025


          Prepare 0.10.1 (python-kasa#1494)

092771d

## [0.10.1](https://github.com/python-kasa/python-kasa/tree/0.10.1) (2025-02-02)

[Full Changelog](python-kasa/python-kasa@0.10.0...0.10.1)

**Release summary:**

Small patch release for bugfixes

**Implemented enhancements:**

- dustbin\_mode: add 'off' mode for cleaner downstream impl [\python-kasa#1488](python-kasa#1488) (@rytilahti)
- Add Dimmer Configuration Support [\python-kasa#1484](python-kasa#1484) (@ryenitcher)

**Fixed bugs:**

- Do not return empty string for custom light effect name [\python-kasa#1491](python-kasa#1491) (@sdb9696)
- Add FeatureAttributes to smartcam Alarm [\python-kasa#1489](python-kasa#1489) (@sdb9696)

**Project maintenance:**

- Add module.device to the public api [\python-kasa#1478](python-kasa#1478) (@sdb9696)

rytilahti added a commit to rytilahti/python-kasa that referenced this pull request

Jul 5, 2026


          Add FeatureAttributes to smartcam Alarm (python-kasa#1489)

f806d15

Co-authored-by: Teemu R. <[email protected]>

rytilahti pushed a commit to rytilahti/python-kasa that referenced this pull request

Jul 5, 2026


          Prepare 0.10.1 (python-kasa#1494)

15a8bf8

## [0.10.1](https://github.com/python-kasa/python-kasa/tree/0.10.1) (2025-02-02)

[Full Changelog](python-kasa/python-kasa@0.10.0...0.10.1)

**Release summary:**

Small patch release for bugfixes

**Implemented enhancements:**

- dustbin\_mode: add 'off' mode for cleaner downstream impl [\python-kasa#1488](python-kasa#1488) (@rytilahti)
- Add Dimmer Configuration Support [\python-kasa#1484](python-kasa#1484) (@ryenitcher)

**Fixed bugs:**

- Do not return empty string for custom light effect name [\python-kasa#1491](python-kasa#1491) (@sdb9696)
- Add FeatureAttributes to smartcam Alarm [\python-kasa#1489](python-kasa#1489) (@sdb9696)

**Project maintenance:**

- Add module.device to the public api [\python-kasa#1478](python-kasa#1478) (@sdb9696)

pillarsdotnet pushed a commit to pillarsdotnet/python-kasa that referenced this pull request

Oct 22, 2026


          Add FeatureAttributes to smartcam Alarm (python-kasa#1489)

74dc5aa

Co-authored-by: Teemu R. <[email protected]>

pillarsdotnet pushed a commit to pillarsdotnet/python-kasa that referenced this pull request

Oct 22, 2026


          Prepare 0.10.1 (python-kasa#1494)

179d5e9

## [0.10.1](https://github.com/python-kasa/python-kasa/tree/0.10.1) (2025-02-02)

[Full Changelog](python-kasa/python-kasa@0.10.0...0.10.1)

**Release summary:**

Small patch release for bugfixes

**Implemented enhancements:**

- dustbin\_mode: add 'off' mode for cleaner downstream impl [\python-kasa#1488](python-kasa#1488) (@rytilahti)
- Add Dimmer Configuration Support [\python-kasa#1484](python-kasa#1484) (@ryenitcher)

**Fixed bugs:**

- Do not return empty string for custom light effect name [\python-kasa#1491](python-kasa#1491) (@sdb9696)
- Add FeatureAttributes to smartcam Alarm [\python-kasa#1489](python-kasa#1489) (@sdb9696)

**Project maintenance:**

- Add module.device to the public api [\python-kasa#1478](python-kasa#1478) (@sdb9696)

Reviewers

rytilahti

rytilahti approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

bug

Something isn't working

Projects

None yet

Milestone

0.10.1

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

sdb9696 commented Jan 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Jan 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

sdb9696 Jan 29, 2025

Choose a reason for hiding this comment

Uh oh!

rytilahti left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sdb9696 commented Jan 27, 2025 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

codecov Bot commented Jan 27, 2025 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.