GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Do not crash on missing build number in fw version by rytilahti · Pull Request #1500 · python-kasa/python-kasa

Conversation

rytilahti commented Feb 9, 2025

Copy link

Copy Markdown

Member

Avoid parsing firmware version if it doesn't contain a whitespace (i.e., build number).

Fixes #1499

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Do not crash on missing build number in fw version

85f94e4

rytilahti added the bug Something isn't working label

Feb 9, 2025

rytilahti mentioned this pull request

Feb 9, 2025

H100 - Raised error: not enough values to unpack (expected 2, got 1) #1499

Closed

codecov Bot commented Feb 9, 2025 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Codecov Report

Attention: Patch coverage is 53.84615% with 6 lines in your changes missing coverage. Please review.

Project coverage is 92.66%. Comparing base (d5187dc) to head (cf165fc).
Report is 8 commits behind head on master.

Files with missing lines	Patch %	Lines
kasa/iot/iotdevice.py	33.33%	1 Missing and 1 partial ⚠️
kasa/smartcam/smartcamchild.py	33.33%	1 Missing and 1 partial ⚠️
kasa/smartcam/smartcamdevice.py	33.33%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1500      +/-   ##
==========================================
- Coverage   92.71%   92.66%   -0.06%     
==========================================
  Files         150      150              
  Lines        9530     9538       +8     
  Branches      970      974       +4     
==========================================
+ Hits         8836     8838       +2     
- Misses        496      499       +3     
- Partials      198      201       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Add fixture

ca5f969

sdb9696 approved these changes

Feb 9, 2025

View reviewed changes

sdb9696 left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

sdb9696 added 2 commits

February 10, 2025 10:44


          Treat new fixture as modify to existing to avoid dupe supported versions

c86cc8b


          Add child temp_humidity_record to smartcam dumpdevinfo

9e0e65c

sdb9696 commented Feb 10, 2025 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

I've updated this PR to treat the fixture as a modify to the existing 1.5.0, as I've confirmed it's exactly the same data (other than the fw_ver), and we don't currently treat the build number as a filename key (avoids two identical lines in SUPPORTED.md). Also fixed dump_devinfo as the get_temp_humidity_records call was not being made as part of the smartcam hub fixture generation.

EDIT: Also applied the same check for no build number to smartcam and iot devices.

rytilahti reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

sdb9696 added this to the 0.10.2 milestone

Feb 10, 2025


          Guard for no build number in all device types

cf165fc

sdb9696 enabled auto-merge (squash)

February 10, 2025 11:11

sdb9696 merged commit 668e32d into master

Feb 10, 2025

sdb9696 deleted the fix/missing_rel_in_fwver branch

February 10, 2025 11:13

rytilahti commented Feb 10, 2025

Copy link

Copy Markdown

Member Author

I was wondering if it'd be better to try-except on version parsing, but this works fine too. Thanks for fixing the CI & merging it! :-)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

sdb9696 mentioned this pull request

Feb 12, 2025

Prepare 0.10.2 #1505

Merged

sdb9696 added a commit that referenced this pull request

Feb 12, 2025


          Prepare 0.10.2 (#1505)

f488492

## [0.10.2](https://github.com/python-kasa/python-kasa/tree/0.10.2) (2025-02-12)

[Full Changelog](0.10.1...0.10.2)

**Release summary:**

- Bugfix for [#1499](#1499).
- Support for L530B and C110 devices.

**Fixed bugs:**

- H100 - Raised error: not enough values to unpack \(expected 2, got 1\) [\#1499](#1499)
- Do not crash on missing build number in fw version [\#1500](#1500) (@rytilahti)

**Added support for devices:**

- Add C110\(EU\) 2.0 1.4.3 fixture [\#1503](#1503) (@sdb9696)
- Add L530B\(EU\) 3.0 1.1.9 fixture [\#1502](#1502) (@sdb9696)

**Project maintenance:**

- Add fixtures for new versions of H100, P110, and T100 devices [\#1501](#1501) (@LXGaming)
- Add L530E\(TW\) 2.0 1.1.1 fixture [\#1497](#1497) (@bluehomewu)

rytilahti added a commit to rytilahti/python-kasa that referenced this pull request

Aug 31, 2025


          Do not crash on missing build number in fw version (python-kasa#1500)

62aa4aa

Co-authored-by: Steven B <[email protected]>

rytilahti pushed a commit to rytilahti/python-kasa that referenced this pull request

Aug 31, 2025


          Prepare 0.10.2 (python-kasa#1505)

21fb7d9

## [0.10.2](https://github.com/python-kasa/python-kasa/tree/0.10.2) (2025-02-12)

[Full Changelog](python-kasa/python-kasa@0.10.1...0.10.2)

**Release summary:**

- Bugfix for [python-kasa#1499](python-kasa#1499).
- Support for L530B and C110 devices.

**Fixed bugs:**

- H100 - Raised error: not enough values to unpack \(expected 2, got 1\) [\python-kasa#1499](python-kasa#1499)
- Do not crash on missing build number in fw version [\python-kasa#1500](python-kasa#1500) (@rytilahti)

**Added support for devices:**

- Add C110\(EU\) 2.0 1.4.3 fixture [\python-kasa#1503](python-kasa#1503) (@sdb9696)
- Add L530B\(EU\) 3.0 1.1.9 fixture [\python-kasa#1502](python-kasa#1502) (@sdb9696)

**Project maintenance:**

- Add fixtures for new versions of H100, P110, and T100 devices [\python-kasa#1501](python-kasa#1501) (@LXGaming)
- Add L530E\(TW\) 2.0 1.1.1 fixture [\python-kasa#1497](python-kasa#1497) (@bluehomewu)

rytilahti added a commit to rytilahti/python-kasa that referenced this pull request

Oct 26, 2025


          Do not crash on missing build number in fw version (python-kasa#1500)

cba142f

Co-authored-by: Steven B <[email protected]>

rytilahti pushed a commit to rytilahti/python-kasa that referenced this pull request

Oct 26, 2025


          Prepare 0.10.2 (python-kasa#1505)

04b744b

## [0.10.2](https://github.com/python-kasa/python-kasa/tree/0.10.2) (2025-02-12)

[Full Changelog](python-kasa/python-kasa@0.10.1...0.10.2)

**Release summary:**

- Bugfix for [python-kasa#1499](python-kasa#1499).
- Support for L530B and C110 devices.

**Fixed bugs:**

- H100 - Raised error: not enough values to unpack \(expected 2, got 1\) [\python-kasa#1499](python-kasa#1499)
- Do not crash on missing build number in fw version [\python-kasa#1500](python-kasa#1500) (@rytilahti)

**Added support for devices:**

- Add C110\(EU\) 2.0 1.4.3 fixture [\python-kasa#1503](python-kasa#1503) (@sdb9696)
- Add L530B\(EU\) 3.0 1.1.9 fixture [\python-kasa#1502](python-kasa#1502) (@sdb9696)

**Project maintenance:**

- Add fixtures for new versions of H100, P110, and T100 devices [\python-kasa#1501](python-kasa#1501) (@LXGaming)
- Add L530E\(TW\) 2.0 1.1.1 fixture [\python-kasa#1497](python-kasa#1497) (@bluehomewu)

rytilahti added a commit to rytilahti/python-kasa that referenced this pull request

Nov 10, 2025


          Do not crash on missing build number in fw version (python-kasa#1500)

b32d330

Co-authored-by: Steven B <[email protected]>

rytilahti pushed a commit to rytilahti/python-kasa that referenced this pull request

Nov 10, 2025


          Prepare 0.10.2 (python-kasa#1505)

d36cb72

## [0.10.2](https://github.com/python-kasa/python-kasa/tree/0.10.2) (2025-02-12)

[Full Changelog](python-kasa/python-kasa@0.10.1...0.10.2)

**Release summary:**

- Bugfix for [python-kasa#1499](python-kasa#1499).
- Support for L530B and C110 devices.

**Fixed bugs:**

- H100 - Raised error: not enough values to unpack \(expected 2, got 1\) [\python-kasa#1499](python-kasa#1499)
- Do not crash on missing build number in fw version [\python-kasa#1500](python-kasa#1500) (@rytilahti)

**Added support for devices:**

- Add C110\(EU\) 2.0 1.4.3 fixture [\python-kasa#1503](python-kasa#1503) (@sdb9696)
- Add L530B\(EU\) 3.0 1.1.9 fixture [\python-kasa#1502](python-kasa#1502) (@sdb9696)

**Project maintenance:**

- Add fixtures for new versions of H100, P110, and T100 devices [\python-kasa#1501](python-kasa#1501) (@LXGaming)
- Add L530E\(TW\) 2.0 1.1.1 fixture [\python-kasa#1497](python-kasa#1497) (@bluehomewu)

rytilahti added a commit to rytilahti/python-kasa that referenced this pull request

Jul 5, 2026


          Do not crash on missing build number in fw version (python-kasa#1500)

46dc41a

Co-authored-by: Steven B <[email protected]>

rytilahti pushed a commit to rytilahti/python-kasa that referenced this pull request

Jul 5, 2026


          Prepare 0.10.2 (python-kasa#1505)

81be16d

## [0.10.2](https://github.com/python-kasa/python-kasa/tree/0.10.2) (2025-02-12)

[Full Changelog](python-kasa/python-kasa@0.10.1...0.10.2)

**Release summary:**

- Bugfix for [python-kasa#1499](python-kasa#1499).
- Support for L530B and C110 devices.

**Fixed bugs:**

- H100 - Raised error: not enough values to unpack \(expected 2, got 1\) [\python-kasa#1499](python-kasa#1499)
- Do not crash on missing build number in fw version [\python-kasa#1500](python-kasa#1500) (@rytilahti)

**Added support for devices:**

- Add C110\(EU\) 2.0 1.4.3 fixture [\python-kasa#1503](python-kasa#1503) (@sdb9696)
- Add L530B\(EU\) 3.0 1.1.9 fixture [\python-kasa#1502](python-kasa#1502) (@sdb9696)

**Project maintenance:**

- Add fixtures for new versions of H100, P110, and T100 devices [\python-kasa#1501](python-kasa#1501) (@LXGaming)
- Add L530E\(TW\) 2.0 1.1.1 fixture [\python-kasa#1497](python-kasa#1497) (@bluehomewu)

pillarsdotnet pushed a commit to pillarsdotnet/python-kasa that referenced this pull request

Oct 22, 2026


          Do not crash on missing build number in fw version (python-kasa#1500)

30c978d

Co-authored-by: Steven B <[email protected]>

pillarsdotnet pushed a commit to pillarsdotnet/python-kasa that referenced this pull request

Oct 22, 2026


          Prepare 0.10.2 (python-kasa#1505)

213de94

## [0.10.2](https://github.com/python-kasa/python-kasa/tree/0.10.2) (2025-02-12)

[Full Changelog](python-kasa/python-kasa@0.10.1...0.10.2)

**Release summary:**

- Bugfix for [python-kasa#1499](python-kasa#1499).
- Support for L530B and C110 devices.

**Fixed bugs:**

- H100 - Raised error: not enough values to unpack \(expected 2, got 1\) [\python-kasa#1499](python-kasa#1499)
- Do not crash on missing build number in fw version [\python-kasa#1500](python-kasa#1500) (@rytilahti)

**Added support for devices:**

- Add C110\(EU\) 2.0 1.4.3 fixture [\python-kasa#1503](python-kasa#1503) (@sdb9696)
- Add L530B\(EU\) 3.0 1.1.9 fixture [\python-kasa#1502](python-kasa#1502) (@sdb9696)

**Project maintenance:**

- Add fixtures for new versions of H100, P110, and T100 devices [\python-kasa#1501](python-kasa#1501) (@LXGaming)
- Add L530E\(TW\) 2.0 1.1.1 fixture [\python-kasa#1497](python-kasa#1497) (@bluehomewu)

Reviewers

sdb9696

sdb9696 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

bug

Something isn't working

Projects

None yet

Milestone

0.10.2

Development

Successfully merging this pull request may close these issues.

H100 - Raised error: not enough values to unpack (expected 2, got 1)

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

rytilahti commented Feb 9, 2025

Uh oh!

codecov Bot commented Feb 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sdb9696 left a comment

Choose a reason for hiding this comment

Uh oh!

sdb9696 commented Feb 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rytilahti commented Feb 10, 2025

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov Bot commented Feb 9, 2025 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

sdb9696 commented Feb 10, 2025 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.