GeezerVison

Some KS200M switches (fw 1.1.4) answer the combined update query with
an unencrypted "200 OK" html page instead of a KLAP response, which
fails to decrypt. Each module answers when it is queried on its own.

Cap max_device_response_size at 2048 for the KS200M, so the update is
split into three requests, the same mechanism IotBulb uses. Other wall
switches keep the default.

Fixes python-kasa#1828

Co-Authored-By: Claude Opus 5.5 <[email protected]>

Some KLAP IoT devices answer a request they reject with a plain
"<html><body><center>200 OK</center></body></html>" page instead of a
KLAP message: KS200M fw 1.1.4 (python-kasa#1828), HS100(UK) hw 4.1 fw 1.1.0 (python-kasa#1790)
and KL125 fw 1.1.1. With an http status line the page failed to decrypt,
without one aiohttp failed with "Bad status line".

KlapTransport now raises _InvalidResponseError for a response that can't
be a KLAP message, and HttpClient raises it when aiohttp can't parse the
response. When an IoT update fails with it, the device queries each
module in its own request from then on and retries the update once, like
SmartProtocol disables multi requests. Strip outlets share the setting
of their parent, whose connection they use.

This replaces the KS200M-only response size cap.

Fixes python-kasa#1828

Co-Authored-By: Claude Opus 5.5 <[email protected]>

The skip moved into _query_modules and had no test.

Co-Authored-By: Claude Opus 5.5 <[email protected]>

rytilahti left a comment

Over KLAP, some IoT devices answer a request whose response would be
larger than about 4 KiB with a plain "200 OK" html page instead of a
KLAP message, and have less room right after a state change.

Use a 2048 byte max_device_response_size for IoT devices on KLAP, so
the update is split by the existing response size estimates, the same
way bulbs use 4096. Bulbs keep 4096 and XOR devices keep 16 KiB.

This replaces the KS200M-only cap, the per-module fallback and the
internal _InvalidResponseError from the earlier commits on this branch.

Co-Authored-By: Claude Opus 5.5 <[email protected]>

A KLAP response is a 32 byte signature followed by whole AES blocks,
signed for the sequence number of the request. Some devices answer with
a plain "200 OK" html page instead, which failed later with "The length
of the provided data is not a multiple of the block length".

Check the length, block alignment and signature first, and raise a
KasaException that says what was wrong and, for a body that is not a
KLAP message, shows its start. As before, IotProtocol does not retry
and resets the session, so the next query does a new handshake.

The logging test's fake device signed its response for the next
sequence number; it now signs for the request's, as devices do.

Co-Authored-By: Claude Opus 5.5 <[email protected]>

rytilahti left a comment •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

The 2048 byte budget and the KS200M split only apply over KLAP, so
their tests now sit with the other KLAP tests, as suggested in review.
tests/iot/test_iotdevice.py and tests/iot/test_wallswitch.py are back
to their master versions.

Co-Authored-By: Claude Opus 5.5 <[email protected]>