GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Handling list merge in _utils.merge_dicts(). by GaetanLepage · Pull Request #38 · python-lsp/python-lsp-server

Conversation

@GaetanLepage

@GaetanLepage GaetanLepage commented Jun 3, 2021

Copy link
Copy Markdown
Contributor

If a list value is present in both dicts, they are merged (with duplicates removed).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@GaetanLepage
Handling list merge in _utils.merge_dicts().
692f3f8
@ccordoba12

ccordoba12 commented Jun 3, 2021

Copy link
Copy Markdown
Member

What problem does this fix? And, could you add a test case for it?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@GaetanLepage

GaetanLepage commented Jun 3, 2021

Copy link
Copy Markdown
Contributor Author

What problem does this fix? And, could you add a test case for it?

In practice, I faced this edge case while having flake8 ignores both in my neovim config (LS client) and others in my project flake8 config (.flake8).
The behavior was that the project ignores were overridden by the project ones.
Thanks to this fix, they are now merged in a single list of ignores (without duplicates).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ccordoba12 ccordoba12 added this to the v1.1.0 milestone Jun 3, 2021
@ccordoba12

ccordoba12 commented Jun 3, 2021

Copy link
Copy Markdown
Member

Ok, I think it's fine. Merging then.
GaetanLepage reacted with rocket emoji
All reactions
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ccordoba12
ccordoba12 merged commit 494e98b into python-lsp:develop Jun 3, 2021
@yangfan-yf-yf yangfan-yf-yf mentioned this pull request Aug 9, 2026
fix: preserve list order when merging settings #723
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.1.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@GaetanLepage @ccordoba12
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.