GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: preserve list order when merging settings by yangfan-yf-yf · Pull Request #723 · python-lsp/python-lsp-server

Conversation

@yangfan-yf-yf

@yangfan-yf-yf yangfan-yf-yf commented Aug 9, 2026

Copy link
Copy Markdown

Fixes #677.

Problem

merge_dicts() merges two list values with list(set(a + b)). The set removes duplicates but also discards first-occurrence order, so configuration lists can vary across hash seeds. This is observable for ordered argument lists such as pylsp_mypy overrides, where option and value positions matter.

The existing merge behavior, introduced in #38, concatenates both lists and removes duplicates. This change preserves that behavior rather than redefining duplicate handling.

Change

  • replace set-based deduplication with dict.fromkeys(...) so the first occurrence wins and list order is stable
  • add regression coverage for cross-list duplicates and a mixed string/boolean override list matching the reported configuration shape

Validation

  • pytest test/test_utils.py -q - 10 passed
  • $env:PYTHONUTF8='1'; python -m pytest test/ -q --deselect=test/test_language_server.py::test_missing_message - 190 passed, 21 skipped, 1 deselected
  • ruff check pylsp test
  • ruff format --check pylsp test
  • git diff --check

test_missing_message is the single deselected test. It times out in this local Windows environment on both the unmodified develop commit and this branch; it does not exercise _utils.merge_dicts.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@yangfan-yf-yf
fix: preserve list order when merging settings
975aebb
@yangfan-yf-yf
yangfan-yf-yf marked this pull request as ready for review August 9, 2026 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Messed plugin config list order

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@yangfan-yf-yf
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.