GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Drop `CancelledError` by clot27 · Pull Request #3754 · python-telegram-bot/python-telegram-bot

Conversation

@clot27

@clot27 clot27 commented Jun 13, 2023

Copy link
Copy Markdown
Member

closes #3731
Used grep to find all usescases of CancelledError

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Aditya
drop cancellederror
f72b462
@Bibo-Joshi
Bibo-Joshi changed the base branch from master to drop-py-37 June 13, 2023 20:13
@Bibo-Joshi
Merge branch 'drop-py-37' into drop-cancellederror
c83823a
@Bibo-Joshi

Bibo-Joshi commented Jun 13, 2023

Copy link
Copy Markdown
Member

Before merging, I'd like to have it double checked that unit tests exit for all the cases were CancelledError was used so far
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Bibo-Joshi
Bibo-Joshi merged commit cf71a38 into drop-py-37 Jun 17, 2023
@Bibo-Joshi
Bibo-Joshi deleted the drop-cancellederror branch June 17, 2023 07:10
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Adopt Py3.8+ features: CancelledError is a subclass of BaseException

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@clot27 @Bibo-Joshi
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.