GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Adopt Py3.8+ features: `CancelledError` is a subclass of `BaseException` · Issue #3731 · python-telegram-bot/python-telegram-bot

Adopt Py3.8+ features: CancelledError is a subclass of BaseException #3731

New issue
Copy link
New issue
Copy link
Closed
#3754
Closed
Adopt Py3.8+ features: CancelledError is a subclass of BaseException#3731
#3754
Copy link
Assignees
clot27
Labels
🛠 code-qualitychange type: code-qualitychange type: code-quality

Description

@Bibo-Joshi
Bibo-Joshi
opened on Jun 2, 2023
Issue body actions

Python 3.8 makes asyncio.CancelledError as subclass of BaseException. As a consequence, it is no longer catched by except Exception clauses and we no longer need special casing in the style of except asyncio.CancelledError.
We review our code base for explicit usages of asyncio.CancelledError and check which ones of them we can drop.

A PR in this direction is very welcome. As long as #3728 is open, it should be based on the drop-py-37 branch. If you would like to send a PR, please be sure to read our contribution guide and leave a short comment so that we can assign you.

Activity

  1. Bibo-Joshi
    added
    🛠 code-qualitychange type: code-qualitychange type: code-quality
    on Jun 2, 2023
  2. clot27
    self-assigned this
    on Jun 13, 2023
  3. Bibo-Joshi
    closed this as completedon Jun 17, 2023
  4. github-actions
    locked and limited conversation to collaborators on Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

  • @clot27
    clot27

Labels

🛠 code-qualitychange type: code-qualitychange type: code-quality

Type

No type

Fields

Priority

None yet

Effort

None yet

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

    You are visitor 01402520 — GeezerVison does not store the pages you look up.
    Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.