GeezerVisonThe World Wide Web, restored to 800 pixels of glory. |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites |
GeezerVison is showing github.com — Match FamilyWild Xauthority entries in get_best_auth by barlowa124 · Pull Request #296 · python-xlib/python-xlib ConversationSummaryFixes #294. XWayland setups (via Mutter) write
New tests in AI-assisted (Devin).
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsXWayland (via Mutter) writes FamilyWild (0xffff) entries with an empty display-number field, intended to match any family, address and display. get_best_auth compared family exactly, so such entries never matched and new_get_auth returned no credentials for :0 despite a valid cookie. Mirror libXau's XauGetBestAuthByAddr: a FamilyWild entry matches any family and address, and an empty entry number matches any display number. Fixes python-xlib#294
Avasam
added a commit
to Avasam/python-xlib
that referenced
this pull request
libXau matches an entry of family `FamilyWild` (65535) against any family and address. Mutter's XWayland writes one next to its `FamilyLocal` entry, so libXau clients still connect when `socket.gethostname()` no longer matches the hostname written there, while `get_best_auth` raised `XNoAuthError`. Based on python-xlib#296. Unlike that PR, a wild entry only applies when no exact entry of the same auth name matched first, like entries without a display number already did, so an exact match still wins regardless of file order. Fixes python-xlib#294. That report's own diagnosis, entries with an empty display number, is already handled since 0.32. Co-authored-by: Avasam <[email protected]>
Avasam
added a commit
to Avasam/python-xlib
that referenced
this pull request
libXau matches an entry of family `FamilyWild` (65535) against any family and address. Mutter's XWayland writes one next to its `FamilyLocal` entry, so libXau clients still connect when `socket.gethostname()` no longer matches the hostname written there, while `get_best_auth` raised `XNoAuthError`. Based on python-xlib#296. Unlike that PR, a wild entry only applies when no exact entry of the same auth name matched first, like entries without a display number already did, so an exact match still wins regardless of file order. Fixes python-xlib#294. That report's own diagnosis, entries with an empty display number, is already handled since 0.32. Co-authored-by: Avasam <[email protected]>
Avasam
added a commit
to Avasam/python-xlib
that referenced
this pull request
libXau matches an entry of family `FamilyWild` (65535) against any family and address. Mutter's XWayland writes one next to its `FamilyLocal` entry, so libXau clients still connect when `socket.gethostname()` no longer matches the hostname written there, while `get_best_auth` raised `XNoAuthError`. Based on python-xlib#296. Unlike that PR, a wild entry only applies when no exact entry of the same auth name matched first, like entries without a display number already did, so an exact match still wins regardless of file order. Fixes python-xlib#294. That report's own diagnosis, entries with an empty display number, is already handled since 0.32. Co-authored-by: Avasam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersNo reviewsUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. new_get_auth() fails to authenticate against Xauthority entries with an empty display number under Wayland/XWaylandUh oh!
There was an error while loading. Please reload this page. 1 participantAdd this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. |
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |