GeezerVison

perf and html look the same so should be good to go if ci passes

@bdraco: perf and html look the same so should be good to go if ci passes

Confirmed on my read — no runtime behavior change, only annotations and .pxd declarations.

Two return annotations look unnecessary. browser.py:268 and registry.py:83. Siblings browser.py:227, _cache.py:185, registry.py:79 keep plain list[DNSOutgoing] / list[DNSRecord] / list[ServiceInfo] against the same list pxd declarations, with inner types cimported, and compile. DNSOutgoing_ serves only line 268.

One gap on "if CI passes": CI won't build with 3.3.0. poetry.lock:291 pins 3.2.9, and the use_cython matrix installs from the lock. Only build_wheels resolves Cython>=3.0.8 unpinned, and it runs after release against master. Run poetry update cython here so the matrix compiles what this PR fixes.

PR Review — fix: build with cython 3.3.0

Solid, well-scoped compatibility fix. Merge-ready; all findings are non-blocking.

The diff is disciplined in the ways that matter for a Cython change. Every altered parameter annotation maps to a real .pxd declaration, and the ones that would have been redundant were correctly left alone — _history.py:45 keeps known_answers: set[DNSRecord] because _history.pxd never cimports DNSRecord, and _updates.py:54 keeps list[RecordUpdate] for the same reason. Each module reuses its own local alias convention (_str/_int in _cache/query_handler/registry, trailing-underscore float_/RecordUpdate_ in info/browser) rather than imposing one. record_manager.py:195 aliases only questions, leaving listener: RecordUpdateListener matching the pxd's RecordUpdateListener listener. The seven touched modules and three dropped @cython.locals entries match the description exactly, and the generated-C / cython -a comparison is the right evidence to bring for a change like this.

No correctness or security concerns: the diff is annotations and .pxd declarations only, with zero runtime behavior change. All new aliases (_ServiceInfo, _DNSIncoming, _RecordUpdate, _DNSQuestion, RecordUpdate_, DNSPointer_) bind names that are imported at runtime, not under TYPE_CHECKING, so no import-time NameError.

• Two return annotations look over-aliased: browser.py:268 and registry.py:83. Siblings with identical pxd shapes and cimported inner types — browser.py:227, _cache.py:185, registry.py:75/79 — keep plain list[DNSOutgoing] / list[DNSRecord] / list[ServiceInfo] and compile. DNSOutgoing_ exists solely for line 268.
• CI never builds with 3.3.0: poetry.lock pins 3.2.9 and the use_cython matrix installs from the lock; the only isolated PEP 517 build (build_wheels) runs after release against master. poetry update cython here would make the pipeline prove the fix.
• The three dropped @cython.locals entries hand hot-path local typing to X | None annotation resolution, where a downgrade to object would be silent (browser.py:531, query_handler.py:358).
• Minor pre-existing cleanup available in the same block being edited: msgs=list at query_handler.pxd:94 duplicates the cython.list msgs parameter.

🟢 Suggestions

cython = "^3.2.9"

Checklist

• No runtime behavior change (annotations and .pxd declarations only)
• All new module-level aliases bind runtime (non-TYPE_CHECKING) imports
• Fix is complete across cythonized modules (unresolvable-inner-type cases correctly skipped)
• CI exercises the Cython version the PR targets — suggestion ＃1
• Diff matches PR description scope (7 modules, 3 locals)
• No security surface touched

Automated review by Kōan (Claude) HEAD=5183d54 7 min 53s