GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Skip garbage collection on process shutdown by filmor · Pull Request #2245 · pythonnet/pythonnet

Skip garbage collection on process shutdown #2245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
filmor wants to merge 6 commits into pythonnet:master from filmor:skip-gc-on-process-shutdown

Uh oh!

There was an error while loading. Please reload this page.
Closed

Skip garbage collection on process shutdown #2245

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8f5a850
Skip garbage collection on process shutdown
filmor Sep 23, 2023
85f74bb
Shut down by default without allowing reload, throw on attempt
filmor Sep 23, 2023
8e4a197
Refactor embed tests to use common fixture
filmor Sep 23, 2023
df53d68
Fix accidental move of Reset call
filmor Sep 23, 2023
4fe3757
Fix refactored tests
filmor Sep 23, 2023
7fc2e1d
Only recover stashed data if the domain is actually changed
filmor Sep 23, 2023
File filter
Filter by extension
Clear filters
Conversations
Failed to load comments.
Loading

Uh oh!

There was an error while loading. Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading

Uh oh!

There was an error while loading. Please reload this page.
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix accidental move of Reset call
  • Loading branch information

Uh oh!

There was an error while loading. Please reload this page.

@filmor
filmor committed Sep 23, 2023
commit df53d68fc387937aeef1aacecd789ed1f43159d7

There are no files selected for viewing

2 changes: 1 addition & 1 deletion 2 src/runtime/Runtime.cs
Show comments
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,9 +312,9 @@ internal static void Shutdown(bool allowReload)
Debug.Assert(everythingSeemsCollected);
}

ResetPyMembers();
Finalizer.Shutdown();
InternString.Shutdown();
ResetPyMembers();

if (!HostedInPython)
{
Expand Down
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.