GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Rename `Args` to `JobArgs` + modify args insert opts check + more tests by brandur · Pull Request #20 · riverqueue/riverqueue-python

Conversation

@brandur

@brandur brandur commented Jul 5, 2024

Copy link
Copy Markdown
Contributor

  • Rename Args to JobArgs for better consistency with other River
    projects.

  • Use a protocol (JobArgsWithInsertOpts) for the check on an args for
    insert_opts() support. (Feels a little more type friendly and also
    how other River projects do it.)

  • Add tests that verify that insert opts are respected correctly and
    various ones that check errors that are returned on invalid insert
    conditions.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@brandur
brandur force-pushed the brandur-insert-opts-tests branch 2 times, most recently from 09f18e3 to 42b6711 Compare July 5, 2024 05:04
@brandur
Rename Args to JobArgs + modify args insert opts check + more tests
fcf8121 
* Rename `Args` to `JobArgs` for better consistency with other River
  projects.

* Use a protocol (`JobArgsWithInsertOpts`) for the check on an args for
  `insert_opts()` support. (Feels a little more type friendly and also
  how other River projects do it.)

* Add tests that verify that insert opts are respected correctly and
  various ones that check errors that are returned on invalid insert
  conditions.
@brandur
brandur force-pushed the brandur-insert-opts-tests branch from 42b6711 to fcf8121 Compare July 5, 2024 05:05
@brandur
brandur merged commit f9095c0 into master Jul 5, 2024
@brandur
brandur deleted the brandur-insert-opts-tests branch July 5, 2024 05:07
brandur added a commit that referenced this pull request Jul 5, 2024
@brandur
Prepare version 0.2.0
a042415 
Prepare release 0.2.0, which largely just includes a rename of `Args` to
`JobArgs`, a new `JobArgsWithInsertOpts` protocol for slightly nicer
typing, and a few more tests [1].

[1] #20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@brandur
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.