GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Implement insert many functions by brandur · Pull Request #22 · riverqueue/riverqueue-python

Conversation

@brandur

@brandur brandur commented Jul 5, 2024

Copy link
Copy Markdown
Contributor

Here, finish the implementations on #insert_many and #insert_many_tx,
which were previously marked as not yet finished. The Python plugin for
sqlc doesn't implement copyfrom, so we instead fall back on an
alternative approach from an experimental database/sql branch I have,
which implements an insert many operation using a combination of Postgres
arrays and unnest.

We remove some Optional annotations on JobInsertParams for properties
that are always set by the client. (Necessary to make MyPy's checks pass
properly.)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@brandur
brandur force-pushed the brandur-insert-many branch 2 times, most recently from ca4b452 to 3b49483 Compare July 5, 2024 06:53
@brandur
Implement insert many functions
efb0faf
Here, finish the implementations on `#insert_many` and `#insert_many_tx`,
which were previously marked as not yet finished. The Python plugin for
sqlc doesn't implement `copyfrom`, so we instead fall back on an
alternative approach from an experimental `database/sql` branch I have,
which implements an insert many operation using a combination of Postgres
arrays and `unnest`.

We remove some `Optional` annotations on `JobInsertParams` for properties
that are always set by the client. (Necessary to make MyPy's checks pass
properly.)
@brandur
brandur force-pushed the brandur-insert-many branch from 3b49483 to efb0faf Compare July 5, 2024 06:57
@brandur
brandur merged commit 178161e into master Jul 5, 2024
@brandur
brandur deleted the brandur-insert-many branch July 5, 2024 06:59
brandur added a commit that referenced this pull request Jul 5, 2024
@brandur
Prepare version 0.3.0
e4947c9
Tee up version 0.3.0, whose largest feature is a full implementation of
`insert_many()` and `insert_many_tx()` [1].

[1] #22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@brandur
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.