GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — rt: don't save and restore xmm/regs in __morestack. by luqmana · Pull Request #5418 · rust-lang/rust

Conversation

@luqmana

@luqmana luqmana commented Mar 17, 2013

Copy link
Copy Markdown
Contributor

Like I commented in #2043, I can't reproduce the weirdness from #1388 on either mac or linux (x84_64) and pushing to try gives all green.

That's 128 less bytes to have to keep in the stack for every call to __morestack.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@luqmana
rt: don't save and restore xmm/regs in __morestack.
f7a14e0
@graydon

graydon commented Mar 18, 2013

Copy link
Copy Markdown
Contributor

Hm. I'm still not sure why they were being clobbered in the meantime. Maybe there was an SSE-using memmove somewhere unaccounted for, or we failed to preserve them across task switches or something?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@brson

brson commented Mar 25, 2013

Copy link
Copy Markdown
Contributor

I'm wary of landing this before 0.6 since I don't think anything notable has changed on the __morestack path to make this problem go away and hitting it depends on exactly where the end of the stack segment is and possibly whether there is already a cached segment.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@brson

brson commented Apr 18, 2013

Copy link
Copy Markdown
Contributor

OK, let's merge this and see what happens!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bors added a commit that referenced this pull request Apr 18, 2013
@bors
auto merge of #5418 : luqmana/rust/stack-float, r=brson
2a86485
Like I commented in #2043, I can't reproduce the weirdness from #1388 on either mac or linux (x84_64) and pushing to try gives all green.

That's 128 less bytes to have to keep in the stack for every call to __morestack.
@bors bors closed this Apr 18, 2013
oli-obk pushed a commit to oli-obk/rust that referenced this pull request May 2, 2020
@flip1995
Rollup merge of rust-lang#5419 - dtolnay:unreadable, r=flip1995
2011d9a
Downgrade unreadable_literal to pedantic

As motivated by rust-lang#5418. This is the top most commonly suppressed Clippy style lint, which indicates that the community has decided they don't share Clippy's opinion on the best style of this.

I've left the lint in as pedantic, though it could be that "restriction" would be better -- I can see this lint being useful as an opt-in restriction in some codebases.

changelog: Remove unreadable_literal from default set of enabled lints
oli-obk pushed a commit to oli-obk/rust that referenced this pull request May 2, 2020
@flip1995
Rollup merge of rust-lang#5420 - dtolnay:newret, r=flip1995
7cb5180
Downgrade new_ret_no_self to pedantic

As motivated by rust-lang#5418. This is the second most widely suppressed Clippy style lint, and [this grep.app search](https://grep.app/search?q=%5C%5Ballow%5C%28.%2Aclippy%3A%3Anew_ret_no_self%5Cb&regexp=true&case=true&filter[lang][0]=Rust) shows a large number of diverse reasonable signatures for a `new` method.

changelog: Remove new_ret_no_self from default set of enabled lints
oli-obk pushed a commit to oli-obk/rust that referenced this pull request May 2, 2020
@bors
Auto merge of rust-lang#5446 - rust-lang:gimme-a-second, r=flip1995
0353f21
compare with the second largest instead of the smallest variant

This should make the lint less noisy for now. See [my comment](rust-lang/rust-clippy#5418 (comment)) to issue rust-lang#5418.

---

changelog: none
U007D pushed a commit to U007D/rust-mos that referenced this pull request Aug 21, 2026
@bors @matklad
Merge rust-lang#5418
f157a09
5418: Continue non-doc comments with trailing space r=matklad a=matklad



bors r+
🤖

Co-authored-by: Aleksey Kladov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@luqmana @graydon @brson @bors
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.