Description

hinerm

opened on May 16, 2024

Issue body actions

Currently, when running mvn install -Dscijava.app.directory="/path/to/Fiji.app" the following superfluous jars are installed:

• scijava-ops-ext-parser
• scijava-ops-indexer
• scijava-ops-tutorial
• scijava-testutil
• scijava-discovery-test

We don't want any of these.

Other fixes:

• platform-specific native jars go into the /jars directory instead of /jars/[platform]
• apiguardian jar is included but I think we don't want it?

Reacted by Gabriel Selzer

Activity

1. gselzer commented on May 20, 2024

   

   gselzer

   on May 20, 2024

   Member

   More actions

   @hinerm @ctrueden does the maven-scijava-plugin provide a mechanism for skipping the scijava:populate-app goal? I don't really understand how you'd prevent installation...
2. hinerm commented on May 20, 2024

   

   hinerm

   on May 20, 2024

   MemberAuthor

   More actions

   @gselzer I think we'd have to isolate the unwanted dependencies and modules.. e.g. with different dependency scopes or Maven profiles. I am doubtful that it is something that can/should be handled at the maven-scijava-plugin level.
3. ctrueden commented on May 20, 2024

   

   ctrueden

   on May 20, 2024

   Member

   More actions

   We don't want any of these.

   This suggests to me that perhaps those specific modules should be put behind profile(s), so that their inclusion in the build is opt-in (and therefore their installation via populate-app is opt-in).

   platform-specific native jars go into the /jars directory instead of /jars/[platform]

   @hinerm Is scijava-maven-plugin >=2.0.0 being used? I thought I fixed this issue years ago as described here?

   apiguardian jar is included but I think we don't want it?

   This dependency comes in because scijava-testutil depends on junit-jupiter-api at compile scope, so the apiguardian dependency comes in transitively also at compile scope. If we hide scijava-testutil behind a profile, this artifact will not be included in app installation.
4. ctrueden commented on May 30, 2024

   

   ctrueden

   on May 30, 2024

   Member

   More actions

   Upon reflection, I think instead we should add some kind of skip property to the scijava-maven-plugin's install-artifact goal. That way, we can still have the whole suite build and run tests and even be mvn installed, but not copy them into a Fiji.app.

   Reacted by Gabriel Selzer

Issue actions