GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — ScriptPacks acceptance test by adamralph · Pull Request #795 · scriptcs/scriptcs

Conversation

@adamralph

@adamralph adamralph commented Jul 13, 2014

Copy link
Copy Markdown
Contributor

fixes #720

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@adamralph adamralph changed the title green: added basic ScriptPacks acceptance test added basic ScriptPacks acceptance test Jul 13, 2014
@adamralph adamralph changed the title added basic ScriptPacks acceptance test ScriptPacks acceptance test Jul 13, 2014
@adamralph

adamralph commented Jul 13, 2014

Copy link
Copy Markdown
Contributor Author

_Fails on TravisCI_ 😢
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@adamralph adamralph added child PR labels Jul 14, 2014
@khellang

khellang commented Jul 14, 2014

Copy link
Copy Markdown
Member

This also contains the commit from #796...
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@adamralph

adamralph commented Jul 14, 2014

Copy link
Copy Markdown
Contributor Author

Yep, this one is on hold (see label). I was just experimenting and I wanted to have the proper error coming out of the installation step. Now that the other PR is merged I'll rebase and continue. At the moment, however, I'm not seeing a path out of the failure on Mono.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@adamralph

adamralph commented Jul 14, 2014

Copy link
Copy Markdown
Contributor Author

I have a suspicion it might be the absolute path to the local gallery for the script pack installation, i.e. /home/.... Changing to a relative path might fix it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@khellang

khellang commented Jul 14, 2014

Copy link
Copy Markdown
Member

Well that didn't work 😝
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@adamralph

adamralph commented Oct 24, 2014

Copy link
Copy Markdown
Contributor Author

Rebased, but still need to fix things for the Mono build.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@adamralph adamralph self-assigned this Dec 17, 2014
adamralph added 2 commits January 3, 2015 13:07
@adamralph
green: added basic ScriptPacks acceptance test
87f266c
@adamralph
green: fixed ScriptPacks acceptance test for *nix
d6b435a
@adamralph

adamralph commented Jan 3, 2015

Copy link
Copy Markdown
Contributor Author

Success at last! This is good to go now.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@adamralph adamralph removed the hold label Jan 3, 2015
@adamralph adamralph removed their assignment Jan 3, 2015
@khellang

khellang commented Jan 3, 2015

Copy link
Copy Markdown
Member

Awesome job @adamralph 😁
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
khellang added a commit that referenced this pull request Jan 3, 2015
@khellang
Merge pull request #795 from adamralph/720
dcfda00 
ScriptPacks acceptance test
@khellang
khellang merged commit dcfda00 into scriptcs:dev Jan 3, 2015
@adamralph
adamralph deleted the 720 branch January 4, 2015 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

child PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Acceptance tests for using a script pack

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@adamralph @khellang
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.