GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — made FileWatcher threadsafe by adamralph · Pull Request #886 · scriptcs/scriptcs

Conversation

@adamralph

@adamralph adamralph commented Jan 3, 2015

Copy link
Copy Markdown
Contributor

The defect https://scan8.coverity.com:8443/reports.htm#v21582/p10801/fileInstanceId=3240428&defectInstanceId=1396798&mergedDefectId=96018 found by Coverity is actually a false positive since the locking was not in place to give public thread safety but only to guarantee correct implementation, given the internal timer thread, but reading the code, it was difficult to tell. I considered suppressing the warning but then I realised making the type threadsafe was actually a trivial change and removes ambiguity for the reader so I thought to go down that route instead.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
adamralph added 2 commits January 3, 2015 18:40
@adamralph
refactor: remove redundant initializer, make _timerLock readonly, mak…
9627965
…e Stop public
@adamralph
refactor: made FileWatcher threadsafe
86ec5fc
@adamralph adamralph added question refactoring and removed question labels Jan 3, 2015
khellang added a commit that referenced this pull request Jan 3, 2015
@khellang
Merge pull request #886 from adamralph/refactor-file-watcher
4b0687e
made FileWatcher threadsafe
@khellang
khellang merged commit 4b0687e into scriptcs:dev Jan 3, 2015
@khellang khellang added this to the v0.13 milestone Jan 3, 2015
@adamralph
adamralph deleted the refactor-file-watcher branch January 4, 2015 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

refactoring

Projects

None yet

Milestone

v0.13

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@adamralph @khellang
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.