GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Refactor PackageInstaller: add guard clauses and replace conditional with Where() by adamralph · Pull Request #888 · scriptcs/scriptcs

Conversation

@adamralph

@adamralph adamralph commented Jan 3, 2015

Copy link
Copy Markdown
Contributor

My attention was drawn to this class by https://scan8.coverity.com:8443/reports.htm#v21582/p10801/fileInstanceId=3240400&defectInstanceId=1396801&mergedDefectId=96016

It's a false positive, but I spotted some low hanging fruit for refactoring, plus a couple of missing guard clauses.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@adamralph
refactor: add guard clauses and replace conditional with Where()
7f8216c
@adamralph adamralph added the refactoring label Jan 3, 2015
khellang added a commit that referenced this pull request Jan 3, 2015
@khellang
Merge pull request #888 from adamralph/refactor-package-installer
364092d 
Refactor PackageInstaller: add guard clauses and replace conditional with Where()
@khellang
khellang merged commit 364092d into scriptcs:dev Jan 3, 2015
@adamralph
adamralph deleted the refactor-package-installer branch January 4, 2015 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

refactoring

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@adamralph @khellang
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.