GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Changes ModuleLoader to ignore native assemblies. Fix for #913 by glennblock · Pull Request #914 · scriptcs/scriptcs

Conversation

@glennblock

@glennblock glennblock commented Feb 4, 2015

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@glennblock

glennblock commented Feb 5, 2015

Copy link
Copy Markdown
Contributor Author

@adamralph looks like Travis CI timed out trying to install some packages.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@adamralph

adamralph commented Feb 5, 2015

Copy link
Copy Markdown
Contributor

Yeah, TravisCI does that sometimes. A re-run usually works.

It looks like there are some genuine failures in the unit tests right now. (TravisCI doesn't run the unit tests yet.)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@glennblock

glennblock commented Feb 5, 2015

Copy link
Copy Markdown
Contributor Author

Yeah I am fixing them.

On Wed Feb 04 2015 at 11:47:29 PM Adam Ralph [email protected]
wrote:

Yeah, TravisCI does that sometimes. A re-run usually works.

It looks like there are some genuine failures in the unit tests right now.
(TravisCI doesn't run the unit tests yet.)

—
Reply to this email directly or view it on GitHub
#914 (comment).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@glennblock

glennblock commented Feb 5, 2015

Copy link
Copy Markdown
Contributor Author

Testing the test fixes now.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@glennblock
glennblock force-pushed the 913 branch 2 times, most recently from a009a79 to 0591db4 Compare February 5, 2015 09:37
@glennblock
Fix for scriptcs#913 to ignore native dlls. Also refactoring
04bec2d 
InitializationServices.
@glennblock
glennblock force-pushed the 913 branch from 260b79f to 04bec2d Compare February 5, 2015 09:49
@glennblock

glennblock commented Feb 5, 2015

Copy link
Copy Markdown
Contributor Author

@sbedford THIS should work!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@adamralph adamralph self-assigned this Feb 5, 2015
@adamralph adamralph added the child PR label Feb 5, 2015
@adamralph

adamralph commented Feb 5, 2015

Copy link
Copy Markdown
Contributor

fixes #913
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
adamralph added a commit that referenced this pull request Feb 5, 2015
@adamralph
Merge pull request #914 from glennblock/913
d48ccc7 
Changes ModuleLoader to ignore native assemblies. Fix for #913
@adamralph
adamralph merged commit d48ccc7 into scriptcs:dev Feb 5, 2015
@adamralph adamralph mentioned this pull request Feb 5, 2015
refactorings from active code review of PR 914 #916
Merged
@glennblock
glennblock deleted the 913 branch December 26, 2015 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@adamralph adamralph

Labels

child PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@glennblock @adamralph
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.