GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Do not use initialize modules MEF catalog if the only module in play is Roslyn or Mono by filipw · Pull Request #965 · scriptcs/scriptcs

Conversation

@filipw

@filipw filipw commented Mar 7, 2015

Copy link
Copy Markdown
Member

Fixes #964

Great perf benefit - improves startup from ~1.5s to ~0.5s.

Tested on Win and OS X

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
filipw added 4 commits March 7, 2015 13:15
@filipw
use reflection instead of MEF if we only need CSharp module
59a279f
@filipw
loader clean up
af0a00d
@filipw
added tests
b2ad97d
@filipw
fixed travis build
563147e
@adamralph adamralph self-assigned this Mar 7, 2015
@adamralph adamralph added the child PR label Mar 7, 2015
@adamralph

adamralph commented Mar 7, 2015

Copy link
Copy Markdown
Contributor

Awesome @filipw!

Although the docker based Travis CI config is a vast improvement, it still fails with the intermittent xunit output path issue 😒. Re-running...
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
adamralph added a commit that referenced this pull request Mar 7, 2015
@adamralph
Merge pull request #965 from filipw/bugfix/964
e5d42bd 
Do not use initialize modules MEF catalog if the only module in play is Roslyn or Mono
@adamralph
adamralph merged commit e5d42bd into scriptcs:dev Mar 7, 2015
@adamralph

adamralph commented Mar 7, 2015

Copy link
Copy Markdown
Contributor

Added #964 to the 0.14 release notes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@adamralph

adamralph commented Mar 7, 2015

Copy link
Copy Markdown
Contributor

I've tested locally and my total time to start REPL in an empty folder has gone from ~2 seconds to ~1 second :fistbump:
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@filipw

filipw commented Mar 7, 2015

Copy link
Copy Markdown
Member Author

I wonder why is it that slow for you though, you have seen the profiler results (against debug build and started from VS) and it's ~500ms. And that's in a VM!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@filipw

filipw commented Mar 7, 2015

Copy link
Copy Markdown
Member Author

:shipit:
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@glennblock glennblock mentioned this pull request Mar 7, 2015
Only scan for modules when -m is specified #964
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@adamralph adamralph

Labels

child PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Only scan for modules when -m is specified

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@filipw @adamralph
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.