GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Add golang based hook-sdk by J12934 · Pull Request #3786 · secureCodeBox/secureCodeBox

Conversation

J12934 commented Aug 25, 2026

Copy link

Copy Markdown

Member

Description

Also migrate fpp hook to have a test / example golang hook

We might migrate more hooks to golang in the future.

Checklist

Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
Make sure that all your commits are signed-off and that you are added to the Contributors file.
Make sure that all CI finish successfully.
Optional (but appreciated): Make sure that all commits are Verified.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

J12934 self-assigned this

Aug 25, 2026

J12934 added this to secureCodeBox

Aug 25, 2026

J12934 added enhancement

New feature or request

hook Implement or update a hook labels

Aug 25, 2026

github-project-automation Bot moved this to Triage in secureCodeBox

Aug 25, 2026

netlify Bot commented Aug 25, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

✅ Deploy Preview for docs-securecodebox canceled.

Name	Link
🔨 Latest commit	`b050de3`
🔍 Latest deploy log	https://app.netlify.com/projects/docs-securecodebox/deploys/6aa0fdd36bf32700092d507a

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

J12934 changed the title ~~Add hook-sdk for golang hooks~~ Add golang based hook-sdk

Aug 25, 2026

Weltraumschaf moved this from Triage to In Progress in secureCodeBox

Aug 26, 2026

J12934 moved this from In Progress to To Review in secureCodeBox

Aug 31, 2026

Weltraumschaf force-pushed the feat/go-hook-sdk branch from 08f426d to a0748c7 Compare

September 1, 2026 11:53

Weltraumschaf requested changes

Sep 1, 2026

View reviewed changes

Comment thread

documentation/docs/api/finding.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

hook-sdk/golang/sdk.go Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

hooks/finding-post-processing/hook/handler.go Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

hooks/finding-post-processing/hook/handler.go Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

parser-sdk/nodejs/findings-schema.json Resolved

Uh oh!

There was an error while loading. Please reload this page.

J12934 mentioned this pull request

Sep 7, 2026

Enforce additionalProperties: false on the finding schema #3797

Open

J12934 requested a review from Weltraumschaf

September 7, 2026 13:03

Weltraumschaf reviewed

Sep 8, 2026

View reviewed changes

Comment thread

hooks/finding-post-processing/hook/handler.go Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

hook-sdk/golang/sdk.go Resolved

Uh oh!

There was an error while loading. Please reload this page.

J12934 force-pushed the feat/go-hook-sdk branch from c8ae534 to c9a2d79 Compare

September 8, 2026 15:33

Weltraumschaf approved these changes

Sep 8, 2026

View reviewed changes

github-project-automation Bot moved this from To Review to Reviewer Approved in secureCodeBox

Sep 8, 2026

J12934 added 10 commits

September 9, 2026 08:33


          Add hook-sdk for golang hooks

500d337

Also migrate fpp hook to have a test / example golang hook

Signed-off-by: Jannik Hollenbach <[email protected]>


          Resolve review comments

3fcc9da

Switchting back to additionalProperties: true to keep backwards
compatability. Opened up secureCodeBox#3797 as a follow up.

Signed-off-by: Jannik Hollenbach <[email protected]>


          Properly set defaults and ensure that node.js hook taskfile builds are

e07ff46

still properly passing

Signed-off-by: Jannik Hollenbach <[email protected]>


          Rework sdk

484e15f

- have the hook request implement the methods in a more straight forward
  way
- pass in ctx into the hook function to keep best practices and ensure
  the funcs remain cancellable
- include a test helper in the sdk to keep hook boilerplate out of the
  hooks

Signed-off-by: Jannik Hollenbach <[email protected]>


          Add some docs for the golang hook sdk

ead2fbf

Signed-off-by: Jannik Hollenbach <[email protected]>


          Have the build context be set more cleanly for new golang based hooks

5a8d81f

Signed-off-by: Jannik Hollenbach <[email protected]>


          Ensure that severities are properly uppercased

e509b8a

were previously validated case insensitivly without normilization
afterwards

Signed-off-by: Jannik Hollenbach <[email protected]>


          Resolve minor inconsistency with url and arg handling

3d52d87

Signed-off-by: Jannik Hollenbach <[email protected]>


          Add a simple test to the sdk

3dca955

Signed-off-by: Jannik Hollenbach <[email protected]>


          add license header stuff

b050de3

Signed-off-by: Jannik Hollenbach <[email protected]>

J12934 force-pushed the feat/go-hook-sdk branch from 725460e to b050de3 Compare

September 9, 2026 06:33

sonarqubecloud Bot commented Sep 9, 2026

Copy link

Copy Markdown

Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

J12934 merged commit 53167dd into secureCodeBox:main

Sep 9, 2026

48 of 49 checks passed

Uh oh!

There was an error while loading. Please reload this page.

github-project-automation Bot moved this from Reviewer Approved to Done in secureCodeBox

Sep 9, 2026

Reviewers

Weltraumschaf

Weltraumschaf approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

J12934

Labels

enhancement

New feature or request

hook

Implement or update a hook

Projects

secureCodeBox

Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

J12934 commented Aug 25, 2026

Description

Checklist

Uh oh!

netlify Bot commented Aug 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for docs-securecodebox canceled.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud Bot commented Sep 9, 2026

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

netlify Bot commented Aug 25, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.