GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Enforce additionalProperties: false on the finding schema · Issue #3797 · secureCodeBox/secureCodeBox

Enforce additionalProperties: false on the finding schema #3797

New issue
Copy link
New issue
Copy link
Open
Task
Open
Enforce additionalProperties: false on the finding schema#3797
Task
Copy link
Labels
breakingChanges requiring a major releaseChanges requiring a major releasefindings
Milestone
v6.0.0

Description

@J12934
J12934
opened on Sep 7, 2026
Issue body actions

Findings schema currently allows arbitrary top-level properties (additionalProperties: true) in parser-sdk/nodejs/findings-schema.json / documentation/docs/api/finding.md, and the Go hook-sdk (hook-sdk/golang/files.go) doesn't reject unknown JSON fields when decoding findings either.

This was kept permissive in #3786 because zap-automation-framework and ssh-audit parsers emit non-standard top-level fields (hint, port) instead of nesting them under attributes.

To do:

  • Move hint (zap-automation-framework) and port (ssh-audit) into attributes
  • Set additionalProperties: false in both schema files
  • Re-enable decoder.DisallowUnknownFields() in hook-sdk/golang/files.go
  • Test and ensure that the nodejs & golang sdk's are properly validating it

This is a breaking change for any parser emitting non-standard top-level finding fields, so it should ship with a major/breaking release.

Reacted by Sven Strittmatter

Activity

  1. J12934
    added this to the v6.0.0 milestone on Sep 7, 2026
  2. J12934
    added the
    Task
    issue type on Sep 7, 2026
  3. J12934
    added
    breakingChanges requiring a major releaseChanges requiring a major release
    findings
    on Sep 7, 2026
  4. github-project-automation
    moved this to Triage in secureCodeBoxon Sep 7, 2026
  5. github-project-automation
    added this to secureCodeBoxon Sep 7, 2026
  6. J12934
    added a commit that references this issue on Sep 7, 2026

    Resolve review comments

    6fd6fe4
  7. J12934
    moved this from Triage to To Review in secureCodeBoxon Sep 7, 2026
  8. J12934
    added 3 commits that reference this issue on Sep 8, 2026

    Resolve review comments

    12db795

    Resolve review comments

    3fcc9da

    Resolve review comments

    6116079
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    breakingChanges requiring a major releaseChanges requiring a major releasefindings

    Type

    Task

    Projects

    • secureCodeBox
      Status
      To Review
      Show more project fields

    Milestone

    • v6.0.0No due date

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

    You are visitor 01402503 — GeezerVison does not store the pages you look up.
    Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.